Skip to content

NO-JIRA: Update PageHeading types#16095

Open
logonoff wants to merge 1 commit intoopenshift:mainfrom
logonoff:pageheading
Open

NO-JIRA: Update PageHeading types#16095
logonoff wants to merge 1 commit intoopenshift:mainfrom
logonoff:pageheading

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Mar 3, 2026

label was changed to ReactNode upstream so we don't need this hack anymroe

Summary by CodeRabbit

  • Breaking Changes
    • Simplified the page heading link component interface by streamlining property declarations. A previously exposed property has been removed from the link configuration. Code using this component should be reviewed and updated accordingly to maintain compatibility with the new interface structure.

`label` was changed to `ReactNode` upstream so we don't need this hack anymroe
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 3, 2026
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request explicitly references no jira issue.

Details

In response to this:

label was changed to ReactNode upstream so we don't need this hack anymroe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

logonoff commented Mar 3, 2026

/label px-approved
/label docs-approved

type only change
/verified bypass

/assign @rhamilto

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Mar 3, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 3, 2026
@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Mar 3, 2026
@openshift-ci-robot
Copy link
Contributor

@logonoff: The verified label has been added.

Details

In response to this:

/label px-approved
/label docs-approved

type only change
/verified bypass

/assign @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cajieh and sg00dwin March 3, 2026 17:50
@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2026
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request explicitly references no jira issue.

Details

In response to this:

label was changed to ReactNode upstream so we don't need this hack anymroe

Summary by CodeRabbit

  • Breaking Changes
  • Simplified the page heading link component interface by streamlining property declarations. A previously exposed property has been removed from the link configuration. Code using this component should be reviewed and updated accordingly to maintain compatibility with the new interface structure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between f913459 and c065b6c.

📒 Files selected for processing (1)
  • frontend/packages/console-shared/src/components/heading/PageHeading.tsx

📝 Walkthrough

Walkthrough

The PageHeadingLinkProps interface in the PageHeading component has been simplified. Previously, it extended Omit<PageHeaderLinkProps, 'label'> with an explicit label: ReactNode | string property declaration. The updated interface now directly extends PageHeaderLinkProps without the explicit label field, reducing the interface definition from 3 lines to 1 line of interface-specific code. This represents a type-level refactoring of the interface contract for link properties used within the page heading component.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update PageHeading types' directly and clearly summarizes the main change—removing the label property workaround from PageHeadingLinkProps after upstream standardization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@logonoff
Copy link
Member Author

logonoff commented Mar 3, 2026

/retest

@logonoff
Copy link
Member Author

logonoff commented Mar 4, 2026

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console c065b6c link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants