NO-JIRA: Add a progress bar when building#16099
NO-JIRA: Add a progress bar when building#16099logonoff wants to merge 2 commits intoopenshift:mainfrom
Conversation
|
@logonoff: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label px-approved |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe webpack configuration was modified to conditionally include the ProgressPlugin in the build pipeline. A spread operator was added to the plugins array that evaluates the REACT_REFRESH and OPENSHIFT_CI environment variables. When either of these variables is truthy, the plugin is excluded; otherwise, it is included. This change affects build behavior specifically in local development and OpenShift CI environments. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
I wanna see what it looks like
|
@logonoff: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| }), | ||
| extractCSS, | ||
| ...(REACT_REFRESH ? [new ReactRefreshWebpackPlugin()] : []), | ||
| ...(REACT_REFRESH ? [new ReactRefreshWebpackPlugin()] : [new webpack.ProgressPlugin()]), |
There was a problem hiding this comment.
When REACT_REFRESH is true, we already know there is a progress bar (because yarn dev has one). so we don't need another.
Whether we want this plugin in CI is another question - ProgressPlugin is compatible with logging but it also makes our build logs a lot more verbose
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
no runtime changes /verified by CI |
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
yarn devdoes it so why notyarn buildSummary by CodeRabbit