Skip to content

NO-JIRA: remove test exception for Insights operator#30849

Open
opokornyy wants to merge 1 commit intoopenshift:mainfrom
opokornyy:insights-exception
Open

NO-JIRA: remove test exception for Insights operator#30849
opokornyy wants to merge 1 commit intoopenshift:mainfrom
opokornyy:insights-exception

Conversation

@opokornyy
Copy link
Contributor

@opokornyy opokornyy commented Mar 9, 2026

Remove the exception used in the test that checks whether the progressing condition is updated during a cluster update.

Summary by CodeRabbit

  • Bug Fixes

    • Removed an exception handling for the Insights operator during cluster upgrade progress checks.
  • Chores

    • Code cleanup with minor whitespace improvements.

Remove the exception used in the test that
checks whether the progressing condition is
updated during a cluster update.

Signed-off-by: Ondrej Pokorny <[email protected]>
@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 9, 2026
@openshift-ci-robot
Copy link

@opokornyy: This pull request explicitly references no jira issue.

Details

In response to this:

Remove the exception used in the test that checks whether the progressing condition is updated during a cluster update.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0f93a9b3-8206-46a2-aec2-23630fef8a4c

📥 Commits

Reviewing files that changed from the base of the PR and between 35bab74 and 5bb87ee.

📒 Files selected for processing (1)
  • pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
💤 Files with no reviewable changes (1)
  • pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

Walkthrough

Removes a specific exception mapping for the Insights operator during upgrade progress checks, eliminating handling for OCPBUGS-65582 in the upgrade window exception logic, with minor whitespace cleanup.

Changes

Cohort / File(s) Summary
Upgrade Exception Handling
pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
Removed exception mapping for Insights operator (OCPBUGS-65582) from upgrade progress check logic; removed stray blank lines.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❓ Inconclusive The specific file mentioned in the PR summary could not be located or accessed in the repository for examination of Ginkgo test names. Verify the file path is correct and accessible. Confirm whether the PR modifies any Ginkgo test name definitions (It, Describe, Context, When). If no test names are modified, the check should pass.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing a test exception for the Insights operator. It is concise, directly related to the changeset, and helps teammates understand the primary modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Structure And Quality ✅ Passed The modified files contain standard Go unit tests and utility functions, not Ginkgo tests, making the custom check not applicable.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@opokornyy
Copy link
Contributor Author

/cc @BaiyangZhou

@openshift-ci openshift-ci bot requested a review from BaiyangZhou March 9, 2026 10:26
@opokornyy
Copy link
Contributor Author

/cc @hongkailiu

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial March 9, 2026 10:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: opokornyy
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from hongkailiu March 9, 2026 10:27
@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2026

@opokornyy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips 5bb87ee link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-microshift 5bb87ee link true /test e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-serial-1of2 5bb87ee link true /test e2e-aws-ovn-serial-1of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants