OCPBUGS-74973: Use Eventually for case that may not work right away

[jluhrsen]

this may just be a test bug that we never hit because the curl timeouts were enough to work first try. but if the first one fails, then using Consistently() would bail immediately, as it should

Summary by CodeRabbit

Release Notes

• Tests
  • Improved DNS reachability test reliability by adjusting polling strategy to be more flexible and better handle network timing variations.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6946fa65-e03e-430b-bfd5-4422ca88e97b

📥 Commits

Reviewing files that changed from the base of the PR and between 56e2119 and 592aa1e.

📒 Files selected for processing (1)

• test/extended/networking/network_segmentation.go

---

Walkthrough

A test assertion for DNS reachability was modified to use eventual consistency semantics instead of strict consistency, changing from a Consistently check to an Eventually check within a specified timeout.

Changes

Cohort / File(s)	Summary
Test Assertion Behavior test/extended/networking/network_segmentation.go	Modified DNS reachability assertion from Consistently to Eventually check for polling behavior evaluation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main change: replacing a Consistently check with Eventually for a DNS reachability assertion that may not succeed immediately.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	All test names are static and deterministic. The Describe block 'NetworkSegmentation' and It blocks contain no dynamic content such as pod names, timestamps, UUIDs, or IP addresses.
Test Structure And Quality	✅ Passed	Change from Consistently to Eventually improves test reliability by properly handling non-immediate DNS reachability conditions with appropriate 5-second timeout.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-74973, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

this may just be a test bug that we never hit because the curl timeouts were enough to work first try. but if the first one fails, then using Consistently() would bail immediately, as it should

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-74973, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

this may just be a test bug that we never hit because the curl timeouts were enough to work first try. but if the first one fails, then using Consistently() would bail immediately, as it should

Summary by CodeRabbit

Release Notes

• Tests
• Improved DNS reachability test reliability by adjusting polling strategy to be more flexible and better handle network timing variations.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
Once this PR has been reviewed and has the lgtm label, please assign kyrtapz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• test/extended/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-fips	592aa1e	link	true	/test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-microshift	592aa1e	link	true	/test e2e-aws-ovn-microshift
ci/prow/e2e-gcp-ovn	592aa1e	link	true	/test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.