Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the compiler “SDL” flag sets used during container builds (and OpenCV-from-source install) to align with the new baseline.
Changes:
- Bumps
_FORTIFY_SOURCEfrom1to3in multiple build flag definitions. - Adds
-D_GLIBCXX_USE_CXX11_ABI=1and-Wuninitializedto the shared flag sets used by OpenCV/Azure/tokenizers/custom-nodes builds. - Removes
-Wno-error=deprecated-declarationsfrom the Azure Storage CMake invocation on Ubuntu.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
third_party/opencv/install_opencv.sh |
Updates the CMake C++ flags used to build OpenCV from source. |
src/custom_nodes/Dockerfile.ubuntu |
Updates compiler flags used when building the sample custom node (Ubuntu). |
src/custom_nodes/Dockerfile.redhat |
Updates compiler flags used when building the sample custom node (Red Hat/UBI). |
Dockerfile.ubuntu |
Updates SDL flags for building cpprestsdk and OpenVINO tokenizers; adjusts Azure Storage build flags on Ubuntu. |
Dockerfile.redhat |
Updates SDL flags for building cpprestsdk and OpenVINO tokenizers on Red Hat. |
|
|
||
| WORKDIR /azure/azure-storage-cpp/Microsoft.WindowsAzure.Storage/build.release | ||
| RUN CASABLANCA_DIR=/azure/cpprestsdk cmake .. -DCMAKE_CXX_FLAGS="${SDL_OPS} -Wno-error=deprecated-declarations" -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -DBoost_USE_STATIC_RUNTIME=ON -DBoost_USE_STATIC_LIBS=ON -DCMAKE_VERBOSE_MAKEFILE=ON && make --jobs=$JOBS && make --jobs=$JOBS install | ||
| RUN CASABLANCA_DIR=/azure/cpprestsdk cmake .. -DCMAKE_CXX_FLAGS="${SDL_OPS}" -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -DBoost_USE_STATIC_RUNTIME=ON -DBoost_USE_STATIC_LIBS=ON -DCMAKE_VERBOSE_MAKEFILE=ON && make --jobs=$JOBS && make --jobs=$JOBS install |
Dockerfile.ubuntu
Outdated
| patch -d /azure/azure-storage-cpp/ -p1 </ovms/third_party/azure/azure_sdk.patch | ||
|
|
||
| ARG SDL_OPS="-fpic -O2 -U_FORTIFY_SOURCE -fstack-protector -fno-omit-frame-pointer -D_FORTIFY_SOURCE=1 -fno-strict-overflow -Wall -Wno-unknown-pragmas -Wno-error=sign-compare -fno-delete-null-pointer-checks -fwrapv -fstack-clash-protection -Wformat -Wformat-security -Werror=format-security" | ||
| ARG SDL_OPS="-fpic -O2 -U_FORTIFY_SOURCE -fstack-protector -D_FORTIFY_SOURCE=3 -fno-strict-overflow -Wall -Wno-unknown-pragmas -Wno-error=sign-compare -fno-delete-null-pointer-checks -fwrapv -fstack-clash-protection -Wformat -Wformat-security -Werror=format-security -D_GLIBCXX_USE_CXX11_ABI=1 -Wuninitialized" |
third_party/opencv/install_opencv.sh
Outdated
| opencv_branch=${opencv_branch:-4.12.0} | ||
| work_dir=${work_dir:-/opt} | ||
| SDL_OPS="-fpic -O2 -U_FORTIFY_SOURCE -fstack-protector -fno-omit-frame-pointer -D_FORTIFY_SOURCE=1 -fno-strict-overflow -Wall -Wno-unknown-pragmas -Wno-error=sign-compare -fno-delete-null-pointer-checks -fwrapv -fstack-clash-protection -Wformat -Wformat-security -Werror=format-security" | ||
| SDL_OPS="-fpic -O2 -U_FORTIFY_SOURCE -fstack-protector -D_FORTIFY_SOURCE=3 -fno-strict-overflow -Wall -Wno-unknown-pragmas -Wno-error=sign-compare -fno-delete-null-pointer-checks -fwrapv -fstack-clash-protection -Wformat -Wformat-security -Werror=format-security -D_GLIBCXX_USE_CXX11_ABI=1 -Wuninitialized" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
SDL flags update
JIRA CVS-181516
🧪 Checklist
``