Remove the internal debug messages.#1386
Open
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Open
Remove the internal debug messages.#1386drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Conversation
Contributor
|
Anything particular to test with this? |
Member
Author
|
The problem that I posted in the corresponding webwork2 pull request is what I used to test this. The |
somiaj
approved these changes
Mar 24, 2026
The only place this is used is for error messages in `lib/PGresponsegroup.pm`. That is now reworked to use the `PGcore::warning_message` method instead. The `internal_debug_messages` is just not needed anymore in addition to the `warning_message` and `debug_message` methods. Furthermore, it is inappropriately named. It has "debug" in the name, but is used for error messages, not debugging messages.
drgrice1
force-pushed
the
remove-internal-debug
branch
from
b13662f to
110d9dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only place this is used is for error messages in
lib/PGresponsegroup.pm. That is now reworked to use thePGcore::warning_messagemethod instead. Theinternal_debug_messagesis just not needed anymore in addition to thewarning_messageanddebug_messagemethods. Furthermore, it is inappropriately named. It has "debug" in the name, but is used for error messages, not debugging messages.Note that this depends on openwebwork/webwork2#2935 for webwork2 to work with this.