Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Dec 23, 2025

The redundante marker should no longer be used.
More info: kubernetes-sigs/controller-tools#1241

Motivation
kube-api-linter only recognize // +required and not the kubebuilder marker

Copilot AI review requested due to automatic review settings December 23, 2025 15:27
@camilamacedo86 camilamacedo86 requested a review from a team as a code owner December 23, 2025 15:27
@netlify
Copy link

netlify bot commented Dec 23, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit d678562
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6980ff980e1755000828ed53
😎 Deploy Preview https://deploy-preview-2407--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the API type definitions by replacing the deprecated +kubebuilder:validation:Required marker with the newer +required marker across all API types. The change is purely a marker update with no functional impact on the generated CRDs.

  • Replaces +kubebuilder:validation:Required with +required in all API type definitions
  • Updates auto-generated API reference documentation to reflect the new marker format
  • Applies the change consistently across ClusterExtension, ClusterExtensionRevision, and ClusterCatalog types

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hack/tools/crd-generator/testdata/api/v1/clusterextension_types.go Updates test data for CRD generator with new required field marker
api/v1/clusterextension_types.go Replaces deprecated required marker in ClusterExtension type definitions
api/v1/clusterextensionrevision_types.go Replaces deprecated required marker in ClusterExtensionRevision type definitions
api/v1/clustercatalog_types.go Replaces deprecated required marker in ClusterCatalog type definitions
docs/api-reference/olmv1-api-reference.md Updates auto-generated API documentation to reflect new marker format

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.53%. Comparing base (e224f78) to head (d678562).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
- Coverage   69.55%   69.53%   -0.03%     
==========================================
  Files         102      102              
  Lines        8354     8354              
==========================================
- Hits         5811     5809       -2     
- Misses       2079     2080       +1     
- Partials      464      465       +1     
Flag Coverage Δ
e2e 46.83% <ø> (ø)
experimental-e2e 13.14% <ø> (ø)
unit 57.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@camilamacedo86 camilamacedo86 changed the title 🌱 Replace deprecated marker for required fields WIP 🌱 Replace deprecated marker for required fields Dec 23, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2025
@camilamacedo86 camilamacedo86 changed the title WIP 🌱 Replace deprecated marker for required fields 🌱 Replace deprecated marker for required fields Dec 23, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2025
@camilamacedo86 camilamacedo86 changed the title 🌱 Replace deprecated marker for required fields WIP 🌱 Replace deprecated marker for required fields Dec 23, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2025
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2025
@camilamacedo86 camilamacedo86 changed the title WIP 🌱 Replace deprecated marker for required fields (Blocked by https://github.com/elastic/crd-ref-docs/pull/192) 🌱 Replace deprecated marker for required fields Dec 24, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2025
@camilamacedo86
Copy link
Contributor Author

When we have a new release with elastic/crd-ref-docs#192 we can check this one again.
For now, I am closing.

@camilamacedo86 camilamacedo86 reopened this Feb 2, 2026
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2026
@camilamacedo86 camilamacedo86 reopened this Feb 2, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2026
@camilamacedo86 camilamacedo86 changed the title (Blocked by https://github.com/elastic/crd-ref-docs/pull/192) 🌱 Replace deprecated marker for required fields (Blocked by #2477) 🌱 Replace deprecated marker for required fields Feb 2, 2026
@camilamacedo86 camilamacedo86 changed the title (Blocked by #2477) 🌱 Replace deprecated marker for required fields 🌱 Replace deprecated marker for required fields Feb 2, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2026
@camilamacedo86
Copy link
Contributor Author

The linter check mark as solved the usage of the deprecated markers
But then because now we are using the marker recognize by it also raise new linter issues about the fields
See: https://github.com/operator-framework/operator-controller/actions/runs/21610044146/job/62276455199?pr=2407

So, we must override

/override api-diff-lint

/override lint-api-diff

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

@camilamacedo86: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • api-diff-lint

Only the following failed contexts/checkruns were expected:

  • Verify PR title
  • crd-diff
  • e2e
  • experimental-e2e
  • extension-developer-e2e
  • go-apidiff
  • go-verdiff
  • goreleaser
  • lint
  • lint-api-diff
  • netlify/olmv1/deploy-preview
  • st2ex-e2e
  • tide
  • unit-test-basic
  • upgrade-st2st-e2e
  • verify

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

The linter check mark as solved the usage of the deprecated markers
But then because now we are using the marker recognize by it also raise new linter issues about the fields
See: https://github.com/operator-framework/operator-controller/actions/runs/21610044146/job/62276455199?pr=2407

So, we must override

/override api-diff-lint

/override lint-api-diff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@camilamacedo86
Copy link
Contributor Author

/override api-diff-lint-override

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

@camilamacedo86: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • api-diff-lint-override

Only the following failed contexts/checkruns were expected:

  • Verify PR title
  • crd-diff
  • e2e
  • experimental-e2e
  • extension-developer-e2e
  • go-apidiff
  • go-verdiff
  • goreleaser
  • lint
  • lint-api-diff
  • netlify/olmv1/deploy-preview
  • st2ex-e2e
  • tide
  • unit-test-basic
  • upgrade-st2st-e2e
  • verify

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override api-diff-lint-override

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants