activity_log_list() and activity_tcx()#113
Open
ken-miyashita wants to merge 1 commit intoorcasgit:masterfrom
Open
activity_log_list() and activity_tcx()#113ken-miyashita wants to merge 1 commit intoorcasgit:masterfrom
ken-miyashita wants to merge 1 commit intoorcasgit:masterfrom
Conversation
fitbit web API supports TCX download. python library supports it.
brad
requested changes
Jan 21, 2017
Member
brad
left a comment
brad
left a comment
There was a problem hiding this comment.
@ken-miyashita This looks really great, thank you for the contribution! One thing, we don't merge new code without tests, would you mind adding some?
Author
|
Of course, you are right. I will add some unit teats for new APIs and again
issue pull request this weekend.
宮下 健 [email protected]
2017/01/21 23:50 "Brad Pitcher" <[email protected]>:
… ***@***.**** requested changes on this pull request.
@ken-miyashita <https://github.com/ken-miyashita> This looks really
great, thank you for the contribution! One thing, we don't merge new code
without tests, would you mind adding some?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#113 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACdP320Qh_AYPlLLDBA1UbJIu7VCU8uMks5rUhsngaJpZM4LqE-A>
.
|
Member
|
Thanks a lot, we appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fitbit web API supports TCX download. python library supports it.