Change example to ES6 imports by dblythy · Pull Request #400 · parse-community/parse-server-example

dblythy · 2021-09-09T00:40:37Z

Changes example project to use import / export instead of require / module.exports
Bumps dependancies

dblythy · 2021-09-23T11:51:59Z

This would be the first branch of #401. I'm thinking this would be what the other branches are based off.

Includes a better example page that actually uses the JS SDK, closing #396.

Moves code to src as per #397.

@sadortun @mtrezza feel free to let me know your thoughts 😃

sadortun

Awesome! This will really help!

I left a few suggestions, feel free to ignore them if you want 😅

sadortun · 2021-09-23T15:34:44Z

README.md

+* `/src/public` contains public assets.
+* `/src/views` contains views that express can render.
+* `/src/config.js` contains all Parse Server settings.
+* `index.js` is the main entry point for `npm start`, and includes express routing.


I would rename index to server.js

I think it’s pretty common practise for index to be the main entry point for package.json

sadortun · 2021-09-23T15:39:52Z

src/config.js

+if (!databaseUri) {
+  console.log('DATABASE_URI not specified, falling back to localhost.');
+}
+export const config = {


We have a type defined for options I think ? ParseServerOptopns ?

You should cast it as that type so user have code completion

That would require babel/typescript though right? I was thinking we could leave that to a TS branch

Mmm, if you import ParseServer, you should also be able to import the Options type

sadortun · 2021-09-23T15:43:36Z

src/config.js

@@ -0,0 +1,14 @@
+const databaseUri = process.env.DATABASE_URI || process.env.MONGODB_URI;


To help with visual clarity, here's 2 ideas

Consider add a helper function that either return the ENV if defined, or default string.

Collect/prepare all variables before the big config object.

sadortun · 2021-09-23T15:49:35Z

src/public/assets/js/script.js

+    updateStatus('Please correct the invalid fields.');
+    return;
+  }
+  await resolve(Parse.User.logIn(username, password));


~~Why do you await resolve() and not just await Parse.User.login() ?~~

Maybe consider renaming resolve to updateStatus or similar. resolve is associated to the thing you call when you completed work inside a promise

Yeah it’s a utility function that handles UI work and resolves the promise. Maybe I should cut it out from this simple version

sadortun · 2021-09-23T15:56:59Z

src/public/assets/js/script.js

+async function saveObject() {
+  if (testObjectSaved) {
+    showTab(2);
+    findObjects();


Missing await?

Nope! This is for moving to the next step after user has already saved an object

sadortun · 2021-09-23T16:01:01Z

src/views/test.html

+    </div>
+    <script src="/public/assets/js/script.js"></script>
+    <script
+      src="https://npmcdn.com/parse@3.3.0/dist/parse.min.js"


Probably for another day ;) but we really need to be able to import Parse from 'parse'

It would allow us to auto update it with NPM

Do tree shaking to reduce package size

better autocompletiom

Can browsers use node imports? Wouldn’t we need a compiler

change to es6 imports

7c529ae

dblythy mentioned this pull request Sep 9, 2021

Cannot specify cloud file string using ES Module parse-community/parse-server#7559

Open

4 tasks

add better scripts page

01eb365

sadortun suggested changes Sep 23, 2021

View reviewed changes

dblythy added 2 commits September 24, 2021 14:45

simplify testing

1371757

Update script.js

ddf60c5

		@@ -0,0 +1,14 @@
		const databaseUri = process.env.DATABASE_URI \|\| process.env.MONGODB_URI;

Uh oh!

Conversation

dblythy commented Sep 9, 2021

Uh oh!

dblythy commented Sep 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadortun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dblythy Sep 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dblythy commented Sep 23, 2021 •

edited

Loading

dblythy Sep 23, 2021 •

edited

Loading