-
Notifications
You must be signed in to change notification settings - Fork 377
feat(GH): update feature template #12225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdated the GitHub feature request issue template with expanded guidance on error handling, keyboard interactions, accessibility considerations, and visual examples across multiple viewport sizes, while changing the design tool reference from Marvel to Figma. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Repos lacking any issue templates: Of these, chatbot, data-view and component-groups may be the most useful to add in a template for as they are more commonly used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/ISSUE_TEMPLATE/feature_request.md (1)
1-23:⚠️ Potential issue | 🔴 CriticalCritical inconsistency: PR linked to wrong issue.
The PR claims to close issue
#287, which is about Enzyme testing approaches and shallow rendering. However, this PR updates a GitHub feature request template with questions about error handling, visuals, accessibility, and release dates—completely unrelated to testing methodology.Please verify whether:
- This PR should link to a different issue about improving the feature request template, or
- The PR description needs correction
🤖 Fix all issues with AI agents
In @.github/ISSUE_TEMPLATE/feature_request.md:
- Line 21: Replace the misspelled word in the user-facing template line "Are
there any specific accessiblity considerations?" by changing "accessiblity" to
"accessibility" so the sentence reads "Are there any specific accessibility
considerations?" and ensure any other occurrences of "accessiblity" in the same
template are corrected as well.
|
|
||
| **Any other information?** | ||
| Does this feature require keyboard interaction or focus management? | ||
| Are there any specific accessiblity considerations? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix spelling error in user-facing template.
The word "accessiblity" is misspelled and should be "accessibility". This is user-facing text in the issue template.
📝 Proposed fix for the spelling error
-Are there any specific accessiblity considerations?
+Are there any specific accessibility considerations?📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Are there any specific accessiblity considerations? | |
| Are there any specific accessibility considerations? |
🧰 Tools
🪛 LanguageTool
[grammar] ~21-~21: Ensure spelling is correct
Context: ...ocus management? Are there any specific accessiblity considerations? **If applicable, what ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🤖 Prompt for AI Agents
In @.github/ISSUE_TEMPLATE/feature_request.md at line 21, Replace the misspelled
word in the user-facing template line "Are there any specific accessiblity
considerations?" by changing "accessiblity" to "accessibility" so the sentence
reads "Are there any specific accessibility considerations?" and ensure any
other occurrences of "accessiblity" in the same template are corrected as well.
|
Other additional questions that could be useful to add, but felt too specific to include for a template / made the template feel too long are listed below. Some of these questions may be useful when thinking about an issue for sizing at least. Design Behavior Accessibility and interaction Definition of done (section in general, maybe more for a PR template?) Misc |
|
Preview: https://pf-react-pr-12225.surge.sh A11y report: https://pf-react-pr-12225-a11y.surge.sh |
What: Closes patternfly/pf-roadmap#287
Updates the template slightly to ask for more relevant data and any deadline to help with prioritization and sizing.
Summary by CodeRabbit