Upgrade dependencies (enable Symfony 6 support), fix some tests#11
Draft
GenieTim wants to merge 1 commit intopfilsx:masterfrom
Draft
Upgrade dependencies (enable Symfony 6 support), fix some tests#11GenieTim wants to merge 1 commit intopfilsx:masterfrom
GenieTim wants to merge 1 commit intopfilsx:masterfrom
Conversation
pfilsx
requested changes
Nov 16, 2022
Owner
pfilsx
left a comment
pfilsx
left a comment
There was a problem hiding this comment.
- Symgony 6 have not been fully implemented(some deps still ^4.0| ^5.0).
- Introduced mixed type-hints set strict php8 requirements, but the php7 requirement remains in the composer.json
| "symfony/twig-bundle": "^4.0 || ^5.0", | ||
| "symfony/dependency-injection": "^4.0 || ^5.0", | ||
| "symfony/dependency-injection": "^4.0 || ^5.0 || ^6.0", | ||
| "symfony/config": "^4.0 || ^5.0", |
| "symfony/framework-bundle": "^4.0 || ^5.0", | ||
| "symfony/framework-bundle": "^4.0 || ^5.0 || ^6.0", | ||
| "symfony/orm-pack": "*", | ||
| "symfony/twig-bundle": "^4.0 || ^5.0", |
| * The return value will be casted to boolean if non-boolean was returned. | ||
| */ | ||
| public final function offsetExists($offset) | ||
| public final function offsetExists(mixed $offset): bool |
Owner
There was a problem hiding this comment.
mixed type-hint support added in PHP8, but in composer.json still PHP7.1 support
| static::$kernel->getContainer()->get('twig'), | ||
| $stack, | ||
| static::$kernel->getContainer()->get('translator') | ||
| // static::$kernel->getContainer()->get('translator') |
Owner
There was a problem hiding this comment.
please no commented code its a bad practice
Author
|
Thanks for the review and the comments, I should have probably marked this as a draft, as I have now. Until all tests are fixed, though that might yet take some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.