Fix hasOffsetValueType with object

[VincentLanglet]

Cf https://www.php.net/manual/en/language.types.array.php

Arrays and objects can not be used as keys. Doing so will result in a warning: Illegal offset type.

So ObjectType::toArrayKey should be an error.

[VincentLanglet]

@ondrejmirtes you reported in #4164

This looks wrong for array{foo: 17, bar: 19}|array{baz: 21}. int|object never exists on these arrays.

The reason was the fact that array[$object] was considered as "Maybe" rather than no,
as shown by https://phpstan.org/r/c6822927-88f1-4a23-a2c0-bb2fb2662e2a

I tried to fix this, but now I'm getting the a LegacyNodeScope test failure because

@var array[array]

is now understood as an error and not mixed ; it's related to

phpstan-src/src/PhpDoc/TypeNodeResolver.php

Line 1230 in 5a39902

return new ErrorType();

Does the change seems ok to you ? If not any idea how I should fix it ?

[VincentLanglet]

What I don't get currently is why

@param array[array]

is considered as mixed by PHPStan, and why

@var array[array]

is considered as *ERROR*.

Changing this might be a correct way to finish this PR ; I'm open to any advice ondrej.

[VincentLanglet]

The behavior for array[array] is now consistent with
https://phpstan.org/r/712fa80d-be94-4efb-b5e7-c700c9c1a76e

So I had to update the test.

[phpstan-bot]

This pull request has been marked as ready for review.

[VincentLanglet]

Phpdoc use array[array]

[ondrejmirtes]

Thank you!