Open
Conversation
StevenClontz
requested changes
Mar 28, 2026
Member
StevenClontz
left a comment
There was a problem hiding this comment.
In addition to considering felixpernegger#2 I'd like to do one more thing...
Look at #241 and see how we added a global store which toggles whether we show redundancies. Add a second checkbox that toggles whether we show LeanLinks. Mark this as experimental and false by default. While we are experimenting, you can do whatever you want with your personal repo that it points to. We'll see how it goes and decide on when/how to make this an official pi-base project. And importantly, we can get this merged over the weekend.
yhx-12243
reviewed
Mar 30, 2026
| height="20" | ||
| viewBox="0 0 486 169" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| stroke="auto" |
Contributor
There was a problem hiding this comment.
auto make it invisible in my local env.
Should change to black, or something.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is a rough implementation for Lean linkage discussed various times now.
As you might guess, this was created by Claude Code (since I cant write TypeScript :( ). I tested a little bit and it seems to be working fine though.
The implementation is similar to the on in erdosproblems.com : If in the pibase lean repo there exists an appropriate file for the theorem/property it links to that and otherwise says "No formalisation available.".
We might wanna use a different repository (make one in github.com/pi-base). I am really not in favour to just use the data repo.
This doesnt read the data off a JSON file (which I think is the case for the normal data?) but just fetches the lean repo directly. I think its acceptable to try this version out and if there are issues, maybe change it later.
Two final issues:
leanOutdated: trueto overwrite linking to the lean repo or something).There are some other things concerning the Lean repo (formatting, CI, tagging IDs properly etc), but this isnt urgent.
I would really appreciate that we can move forward with this PR quickly, so to avoid the issues outlined above, I heavily trimmed the lean repo to only contain definitions which are (basically) in mathlib
@StevenClontz