feat: create plotly.js bundle map programmatically #2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates the proper `bundleTraceMap` list as internal data object directly from the upstream JS file when updating plotly.js. This commit adds an updated `bundleTraceMap` for the currently used plotly.js v2.11.1 to `R/sysdata.rda`.
Contributor
Author
|
Note that the failing tests are unrelated to this PR, AFAICT. |
cpsievert
reviewed
Jan 31, 2024
cpsievert
reviewed
Jan 31, 2024
This makes non-base-R dependencies clearly apparent
Contributor
Author
|
@cpsievert Anything else I need to do to get this merged? |
cpsievert
reviewed
Sep 3, 2024
cpsievert
reviewed
Sep 3, 2024
cpsievert
reviewed
Sep 3, 2024
salim-b
changed the title
Contributor
Author
|
@cpsievert I've updated this PR to the latest changes. I'd be glad if you could merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the proper
bundleTraceMaplist as internal package data object directly from the upstream JS file when plotly.js is updated.The data is sourced from the file
tasks/util/constants.jsof the matching plotly.js Git tagviayay::gh_text_file(), which I wrote. The package is not (yet) available on CRAN and thus must be installed viaremotes::install_gitlab("rpkg.dev/yay")for the time being. I think this shouldn't be an issue sincetools/update_plotlyjs.Ris run manually during development and is not intended to be run by users.This commit adds an updated
bundleTraceMapfor the currently used plotly.js v2.25.2 toR/sysdata.rda, which now also includes plotly.js'strictbundle, so nowplotly::partial_bundle(type = "strict")works as intended.