Skip to content

Conversation

@limzykenneth
Copy link
Member

Changes:

Updating dependencies where relevant and corresponding build/test updates as well.

WIP, this probably don't need to make it into 2.2 and can make 2.3.

@limzykenneth
Copy link
Member Author

@davepagurek CI failed on type tests

Error: test/types/typography.ts(50,23): error TS2550: Property 'at' does not exist on type 'Vector[]'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2022' or later.

Is there meant to be a tsconfig for us to define these things?

@davepagurek
Copy link
Contributor

@limzykenneth not yet, but we could update the script in package.json to be npx tsc --project test/types/tsconfig.json --noEmit test/types/*.ts, and then create test/types/tsconfig.json with:

{
  "compilerOptions": {
    "lib": "es2022"
  }
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davepagurek I'm not entirely sure what the error here means, do you have some idea where it could have occurred?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeError: Cannot read properties of undefined (reading 'ensureCompiledOnContext')
 ❯ Renderer3D.shader src/webgl/material.js:3716:7
    3714|     this.states.setValue("userFillShader", s);
    3715|     this.states.setValue("_useNormalMaterial", false);
    3716|     s.ensureCompiledOnContext(this);
       |       ^
    3717|     s.setDefaultUniforms();
    3718|   };

I think that test uses a custom shader, but possibly after some changes, it's no longer returning that shader. Looks like s, the shader variable, is undefined here for some reason. I can take a closer look later if its not obvious how that could have happened

@limzykenneth limzykenneth marked this pull request as ready for review January 30, 2026 14:36
@limzykenneth
Copy link
Member Author

@ksen0 @davepagurek Once the test error is sorted I'd like to get this merged or there will be more and more merge conflict here and in other PRs after this has been merged. There are still some maintenance stuff I'd still like to do but I can do them as later PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants