-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Dependencies updates #8360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-2.0
Are you sure you want to change the base?
Dependencies updates #8360
Conversation
|
@davepagurek CI failed on type tests
Is there meant to be a tsconfig for us to define these things? |
|
@limzykenneth not yet, but we could update the script in package.json to be {
"compilerOptions": {
"lib": "es2022"
}
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davepagurek I'm not entirely sure what the error here means, do you have some idea where it could have occurred?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TypeError: Cannot read properties of undefined (reading 'ensureCompiledOnContext')
❯ Renderer3D.shader src/webgl/material.js:3716:7
3714| this.states.setValue("userFillShader", s);
3715| this.states.setValue("_useNormalMaterial", false);
3716| s.ensureCompiledOnContext(this);
| ^
3717| s.setDefaultUniforms();
3718| };
I think that test uses a custom shader, but possibly after some changes, it's no longer returning that shader. Looks like s, the shader variable, is undefined here for some reason. I can take a closer look later if its not obvious how that could have happened
|
@ksen0 @davepagurek Once the test error is sorted I'd like to get this merged or there will be more and more merge conflict here and in other PRs after this has been merged. There are still some maintenance stuff I'd still like to do but I can do them as later PRs. |
Changes:
Updating dependencies where relevant and corresponding build/test updates as well.
WIP, this probably don't need to make it into 2.2 and can make 2.3.