Rip out support for end-of-life Ruby versions#328
Merged
Conversation
We've been carrying support for a bunch of EOL Ruby versions on the basis that it was easy. Adding support for Ruby 4.0 means adding `cgi` as an explicit dependency as it is no longer a default gem. The latest version of it is incompatible with JRuby 9.1, which targets Ruby 2.x compatibility (while JRuby targets more specific Ruby versions now, before JRuby 9.2, it followed whatever the latest version of 2.x was). We might be able to find a way to conditionally avoid installing the gem on that version of JRuby and let it use the included version, but at this point I don't want to pile on more hacks to support EOL versions of Ruby that have been out of support for a long time. There are better places to spend effort on this library. Let's take the opportunity to officially drop all currently EOL Ruby versions. I'll bump the major version in the next release. Signed-off-by: Chris Sinjakli <[email protected]>
This was referenced Feb 1, 2026
Collaborator
|
I wonder if you want to remove 3.2 too... it goes away in ~2 months, and I doubt we'll introduce something that breaks it but passes in 3.3... |
dmagliola
approved these changes
Feb 5, 2026
Member
Author
|
I was tempted, but it feels weird to drop it preemptively. I think I'd rather leave it in and bump the major version again if 3.2 starts causing problems for us after it falls out of support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been carrying support for a bunch of EOL Ruby versions on the basis that it was easy. Adding support for Ruby 4.0 means adding
cgias an explicit dependency as it is no longer a default gem. The latest version of it is incompatible with JRuby 9.1, which targets Ruby 2.x compatibility (while JRuby targets more specific Ruby versions now, before JRuby 9.2, it followed whatever the latest version of 2.x was).We might be able to find a way to conditionally avoid installing the gem on that version of JRuby and let it use the included version, but at this point I don't want to pile on more hacks to support EOL versions of Ruby that have been out of support for a long time. There are better places to spend effort on this library.
Let's take the opportunity to officially drop all currently EOL Ruby versions. I'll bump the major version in the next release.