Open
Conversation
ananthb
force-pushed
the
bcachefs-collector
branch
5 times, most recently
from
b1d2f00 to
bd5c99d
Compare
SuperQ
reviewed
Feb 10, 2026
SuperQ
requested changes
Feb 10, 2026
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Please move the raw file parsing to https://github.com/prometheus/procfs/tree/master/bcache.
ananthb
force-pushed
the
bcachefs-collector
branch
from
bd5c99d to
aacd2a5
Compare
Author
|
I've re-worked the code with the changes from procfs master and they look good. If you want to cut a new release of procfs I can use it here. |
ananthb
force-pushed
the
bcachefs-collector
branch
from
aacd2a5 to
db43e71
Compare
Member
|
I will try and cut a procfs release in the next day or so. |
SuperQ
reviewed
Feb 27, 2026
ananthb
force-pushed
the
bcachefs-collector
branch
2 times, most recently
from
98c4669 to
fe8cbbd
Compare
ananthb
force-pushed
the
bcachefs-collector
branch
from
fe8cbbd to
64ddd7c
Compare
Author
|
@SuperQ my testdata was out of date in https://github.com/prometheus/procfs so the code wasn't working with current bcachefs. I've fixed it here and tested it. |
ananthb
force-pushed
the
bcachefs-collector
branch
3 times, most recently
from
d5e6a5e to
9c9377d
Compare
SuperQ
reviewed
Feb 28, 2026
ananthb
force-pushed
the
bcachefs-collector
branch
2 times, most recently
from
03b2a63 to
736a1cd
Compare
ananthb
force-pushed
the
bcachefs-collector
branch
3 times, most recently
from
18fe25e to
e87dd71
Compare
Add support for collecting and reporting metrics from bcachefs filesystems. Signed-off-by: Ananth Bhaskararaman <antsub@gmail.com>
ananthb
force-pushed
the
bcachefs-collector
branch
from
e87dd71 to
f514311
Compare
SuperQ
reviewed
Mar 2, 2026
Comment on lines
+72
to
+77
| prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, subsystem, "info"), | ||
| "Filesystem information.", | ||
| []string{"uuid"}, | ||
| nil, | ||
| ), |
Member
There was a problem hiding this comment.
Would you mind refactoring these to be package-level vars? This way they're defined once at compile time. Small performance improvement, but it reduces Go GC over time.
Suggested change
| prometheus.NewDesc( | |
| prometheus.BuildFQName(namespace, subsystem, "info"), | |
| "Filesystem information.", | |
| []string{"uuid"}, | |
| nil, | |
| ), | |
| var ( | |
| bcachefsInfoDesc = prometheus.NewDesc( | |
| prometheus.BuildFQName(namespace, subsystem, "info"), | |
| "Filesystem information.", | |
| []string{"uuid"}, | |
| nil, | |
| ) | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for collecting and reporting metrics from bcachefs filesystems.