audit: Fix false path conflict for equivalent relative paths#291
Open
febyeji wants to merge 2 commits intopulp-platform:masterfrom
Open
audit: Fix false path conflict for equivalent relative paths#291febyeji wants to merge 2 commits intopulp-platform:masterfrom
febyeji wants to merge 2 commits intopulp-platform:masterfrom
Conversation
- Canonicalize path dependencies before comparing sources in `audit` and `parents` commands. - Add `format_dep_source()` helper that resolves path dependencies relative to each package's root directory before formatting - Add regression test for the fix. Fixes pulp-platform#290
bender audit should return correctly, as it only provides information. Add bender parents to identify paths in case of conflict.
micprog
approved these changes
Mar 27, 2026
Member
micprog
left a comment
micprog
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick fix and test! 👍
I added a bit more print to the test, but that is only in case there is a mismatch to gain some insight, should not happen.
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bender audit reports a false path conflict when multiple packages reference the same directory via different relative paths (e.g., ip/common vs ../common).
This PR fixes the issue by:
auditandparentscommands.format_dep_source()helper that resolves path dependencies relative to each package's root directory before formattingFixes #290