Merged
Conversation
confused-Techie
approved these changes
Dec 13, 2023
Member
confused-Techie
left a comment
There was a problem hiding this comment.
This PR does in fact just do the bump as expected.
Although without tests hard to tell exactly where we are. But fingers crossed we are good to go
Member
Author
|
Looking at the CI, the baseline state of things isn't super great but I don't see anything that looks truly like a new issue as of this PR.
|
Member
Author
|
Basically working on my machine, didn't throw any errors on startup, was able to sync latest commits from the remote for my local clone of pulsar repo. I'll merge this and ask @Daeraxa if this works on their ARM Linux machines before doing a PR to core? (How to test: EDIT: Thanks for review!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
master, as I'm not set up to sync the superstring bump across all three packages that depend on it at once just yet)Screenshot or Gif
N/A
Applicable Issues
See also: pulsar-edit/whats-my-line#8
Follows up on: #36