Draft
Conversation
|
Hi @DavidDotCheck - do you think you'll finish this PR up? Or is it just for demo purposes? |
Author
|
It's just for demo purposes since I didn't get any feedback or interest. I'm open to polishing it up and finishing the PR, but there are a few questions and problems in the way for now so until it get's some momentum or help, it will probably take a while.
I also had to make a lot of unrelated changes to the code and encountered quite a few errors and bugs that I had to fix, which makes me wonder if I set up my environment wrong. |
|
Okay, thanks for the detailed update! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
As mentioned in #561, PTY is currently missing support on windows, which somewhat limits
invoke's usefulness for windows users.I quickly threw together a PR to demo the changes necessary, which I present here as a starting of point.
Changes:
pywinptyon Windows.dev-requirements.txtNotes:
Testing: