new error code: ASYNC914 unnecessary checkpoints + autofix#183
new error code: ASYNC914 unnecessary checkpoints + autofix#183jakkdl wants to merge 3 commits intopython-trio:mainfrom
Conversation
|
I picked this up and worked on it somewhat recently, but stalled out due to the complexity. The complexity is mostly because it's hard to resist solving the juicy edge cases and autofixing everything, so next time I pick this up I'll just drop the complex parts, see if the basic cases that are working are worth having as a rule, and clean up the PR so it can be merged. |
5e44a59 to
358df6d
Compare
|
picked this one up to get it done and dusted. I tried to do simple solutions to avoid the complexity trap I previously fell into, but that only led to further problems and in the end I essentially needed to implement the reverse of the logic in 910/911/913. I also replaced a lot of I also ended up adding asyncio autofixing support to 910/911/913 by having them insert |
fixes #70 (merely 5 months after it was opened 😁)
Early WIP, I only got the basic case down.
I started on this before #182, but I'm prioritizing that one.
Remaining TODO:
ifstatementsifis solved this can probably use similar logic, but it'll likely be messy