use sys.get_asyncgen_hooks().finalizer to sniff io#28
Draft
graingert wants to merge 6 commits intopython-trio:masterfrom
Draft
use sys.get_asyncgen_hooks().finalizer to sniff io#28graingert wants to merge 6 commits intopython-trio:masterfrom
graingert wants to merge 6 commits intopython-trio:masterfrom
Conversation
Member
Author
|
This is based on the observation that the primary purpose of an async framework is to collect async generator objects, close them correctly and raise a resource warning. sniffio is no longer answering the question of "what sort of object should I _async_yield", it's answering "if I de-reference a an async generator where does it go?" |
graingert
commented
Aug 3, 2022
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 96.51% 87.34% -9.17%
==========================================
Files 4 4
Lines 86 158 +72
Branches 17 22 +5
==========================================
+ Hits 83 138 +55
- Misses 2 17 +15
- Partials 1 3 +2
🚀 New features to boost your workflow:
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20 #27