gh-140715: provide support for %F token in strptime; add test for it and %T #140647

jyalim · 2025-10-27T00:07:35Z

Incrementally builds C99+ datetime support with addition of %F with single line of code. Also adds two tests: one for %F and another for previously supported %T.

Passed all tests (especially changes to new one).

Passed patchcheck.

Issue: strptime token support and documentation modernization #140644

Issue: Update str*time to C11 format codes #140715

bedevere-app · 2025-10-27T00:07:39Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

python-cla-bot · 2025-10-27T00:07:39Z

All commit authors signed the Contributor License Agreement.

Lib/_strptime.py

Misc/NEWS.d/next/Library/2025-10-27-00-13-04.gh-issue-140644.WkozE0.rst

Lib/test/test_strptime.py

StanFromIreland · 2025-10-28T18:34:06Z

I moved this under #140715, can you please update the blurb filename.

Co-authored-by: Stan Ulbrych <[email protected]>

…kozE0.rst Co-authored-by: Stan Ulbrych <[email protected]>

jyalim · 2025-10-28T21:14:32Z

I moved this under #140715, can you please update the blurb filename.

I think this is done!

Lib/test/test_strptime.py

Misc/NEWS.d/next/Library/2025-10-27-00-13-04.gh-issue-140715.WkozE0.rst

Co-authored-by: Stan Ulbrych <[email protected]>

….py` instead)

StanFromIreland

Please add them to this tuple:

cpython/Lib/test/test_time.py

Lines 361 to 363 in a2495ff

    
           for directive in ('a', 'A', 'b', 'B', 'c', 'd', 'H', 'I', 
        
                             'j', 'm', 'M', 'p', 'S', 
        
                             'U', 'w', 'W', 'x', 'X', 'y', 'Y', 'Z', '%'):

Also, please update the docs removing the (0) note from its row.

The implementation looks good, just a few small things and this will be ready :-)

Misc/NEWS.d/next/Library/2025-10-27-00-13-04.gh-issue-140715.WkozE0.rst

Lib/test/test_strptime.py

Lib/test/datetimetester.py

…kozE0.rst Co-authored-by: Stan Ulbrych <[email protected]>

Remove extra comments Co-authored-by: Stan Ulbrych <[email protected]>

shorten test name Co-authored-by: Stan Ulbrych <[email protected]>

shorten test function name Co-authored-by: Stan Ulbrych <[email protected]>

…tester request

…oken symmetry

jyalim · 2026-02-07T23:04:46Z

Thank you, @StanFromIreland, all changes have been made as requested!

Doc/library/datetime.rst

jyalim · 2026-02-08T14:52:00Z

Thank you again, @StanFromIreland, changes have been made.

StanFromIreland

Last few things.

Doc/library/datetime.rst

Lib/test/datetimetester.py

Lib/test/test_strptime.py

Lib/test/datetimetester.py

style alignment, add space after function arguments as requested Co-authored-by: Stan Ulbrych <[email protected]>

fix punctuation in docs, as requested Co-authored-by: Stan Ulbrych <[email protected]>

style alignment, space after functional argument, as requested Co-authored-by: Stan Ulbrych <[email protected]>

…p.) and use `self.theclass.strptime`

jyalim · 2026-02-08T20:56:16Z

Thanks, @StanFromIreland, the requested changes were implemented!

Lib/test/datetimetester.py

StanFromIreland

LGTM

StanFromIreland · 2026-02-09T12:30:30Z

Thanks @jyalim, and congratulations for your first PR! Do you want to open a PR for one of the other format codes?

provide support for %F token in strptime; add test for it and %T

92929d8

jyalim requested review from abalkin and pganssle as code owners October 27, 2025 00:07

bedevere-app bot added the awaiting review label Oct 27, 2025

bedevere-app bot mentioned this pull request Oct 27, 2025

strptime token support and documentation modernization #140644

Closed

📜🤖 Added by blurb_it.

b1bf9b4

StanFromIreland reviewed Oct 27, 2025

View reviewed changes

Lib/_strptime.py Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2025-10-27-00-13-04.gh-issue-140644.WkozE0.rst Outdated Show resolved Hide resolved

Lib/test/test_strptime.py Outdated Show resolved Hide resolved

StanFromIreland changed the title ~~gh-140644: provide support for %F token in strptime; add test for it and %T~~ gh-140715: provide support for %F token in strptime; add test for it and %T Oct 28, 2025

bedevere-app bot mentioned this pull request Oct 28, 2025

Update str*time to C11 format codes #140715

Open

4 tasks

jyalim and others added 3 commits October 28, 2025 14:10

rm comment as recommended

d84fd54

Co-authored-by: Stan Ulbrych <[email protected]>

Update Misc/NEWS.d/next/Library/2025-10-27-00-13-04.gh-issue-140644.W…

cb8d7d3

…kozE0.rst Co-authored-by: Stan Ulbrych <[email protected]>

Rename NEWS blurbit to match new github issue name

634ecea

Update test_strptime.py to use unittest methods, as requested

2e94037

StanFromIreland reviewed Oct 28, 2025

View reviewed changes

Lib/test/test_strptime.py Outdated Show resolved Hide resolved

Lib/test/test_strptime.py Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2025-10-27-00-13-04.gh-issue-140715.WkozE0.rst Outdated Show resolved Hide resolved

jyalim and others added 4 commits October 28, 2025 14:36

simplify news per recommendation

c23b731

Co-authored-by: Stan Ulbrych <[email protected]>

Remove datetime tests from test_strptime.py (added to `datetimetester…

e77ff96

….py` instead)

Tests moved to datetimetester.py

ffbc215

Merge branch 'main' into fix-issue-140644

fb63ae7

StanFromIreland reviewed Feb 7, 2026

View reviewed changes

jyalim and others added 7 commits February 7, 2026 15:24

Update Misc/NEWS.d/next/Library/2025-10-27-00-13-04.gh-issue-140715.W…

ff10b73

…kozE0.rst Co-authored-by: Stan Ulbrych <[email protected]>

Update Lib/test/test_strptime.py

b4ec5f8

Remove extra comments Co-authored-by: Stan Ulbrych <[email protected]>

Update Lib/test/datetimetester.py

8513e1d

shorten test name Co-authored-by: Stan Ulbrych <[email protected]>

Update Lib/test/datetimetester.py

0a928e6

shorten test function name Co-authored-by: Stan Ulbrych <[email protected]>

refactor test for %F as requested

029ed4f

refactor test for %F and %T as requested

88c6f02

refactor test %T as requested; rename %F + %T tests to match datetime…

707ea08

…tester request

jyalim added 2 commits February 7, 2026 15:55

add %F and %T tests, as requested, for ensuring strptime & strftime t…

c61cb2f

…oken symmetry

remove (0) note for %F in documentation, as requested

10ab774

StanFromIreland reviewed Feb 8, 2026

View reviewed changes

Doc/library/datetime.rst Outdated Show resolved Hide resolved

Doc/library/datetime.rst Outdated Show resolved Hide resolved

jyalim added 2 commits February 8, 2026 07:33

revert date change in

179afae

documenting %F addition to strptime

f56f54a

StanFromIreland reviewed Feb 8, 2026

View reviewed changes

jyalim and others added 7 commits February 8, 2026 13:30

Update Lib/test/test_strptime.py

29ba043

style alignment, add space after function arguments as requested Co-authored-by: Stan Ulbrych <[email protected]>

Update Lib/test/datetimetester.py

7d4c618

style alignment, add space after function arguments as requested Co-authored-by: Stan Ulbrych <[email protected]>

Update Doc/library/datetime.rst

2cf4890

fix punctuation in docs, as requested Co-authored-by: Stan Ulbrych <[email protected]>

Update Doc/library/datetime.rst

c5593dd

fix punctuation in docs, as requested Co-authored-by: Stan Ulbrych <[email protected]>

Update Lib/test/test_strptime.py

b0ca1d2

style alignment, space after functional argument, as requested Co-authored-by: Stan Ulbrych <[email protected]>

Update Lib/test/datetimetester.py

46981d1

style alignment, space after functional argument, as requested Co-authored-by: Stan Ulbrych <[email protected]>

relocate test methods for %F and %T to TestDate and TestDateTime (res…

500552b

…p.) and use `self.theclass.strptime`

StanFromIreland reviewed Feb 8, 2026

View reviewed changes

Lib/test/datetimetester.py Show resolved Hide resolved

Update Lib/test/datetimetester.py

18757eb

StanFromIreland approved these changes Feb 8, 2026

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels Feb 8, 2026

encukou merged commit d99f3fc into python:main Feb 9, 2026
51 checks passed

bedevere-app bot removed the awaiting core review label Feb 9, 2026

	for directive in ('a', 'A', 'b', 'B', 'c', 'd', 'H', 'I',
	'j', 'm', 'M', 'p', 'S',
	'U', 'w', 'W', 'x', 'X', 'y', 'Y', 'Z', '%'):

Uh oh!

gh-140715: provide support for %F token in strptime; add test for it and %T #140647

gh-140715: provide support for %F token in strptime; add test for it and %T #140647

Uh oh!

Conversation

jyalim commented Oct 27, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-app bot commented Oct 27, 2025

Uh oh!

python-cla-bot bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StanFromIreland commented Oct 28, 2025

Uh oh!

jyalim commented Oct 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jyalim commented Feb 7, 2026

Uh oh!

Uh oh!

Uh oh!

jyalim commented Feb 8, 2026

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jyalim commented Feb 8, 2026

Uh oh!

Uh oh!

StanFromIreland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

StanFromIreland commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jyalim commented Oct 27, 2025 •

edited by bedevere-app bot

Loading

python-cla-bot bot commented Oct 27, 2025 •

edited

Loading