-
-
Notifications
You must be signed in to change notification settings - Fork 34k
gh-136216: Update JSON RFC references from 7159 to 8259 #144453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Doc/library/json.rst
Outdated
| boolean, number, or string value. :rfc:`7159` (now :rfc:`8259`) removed that | ||
| restriction, and this module does not and has never implemented that restriction | ||
| in either its serializer or its deserializer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not change the flow of the text here. Reduce the diff.
|
|
||
| .. [#rfc-errata] As noted in `the errata for RFC 7159 | ||
| <https://www.rfc-editor.org/errata_search.php?rfc=7159>`_, | ||
| .. [#rfc-errata] As noted in `the errata for RFC 8259 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be careful here. Is it still the correct errata?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have an answer here. I'm surprised that both RFCs have the same errata.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
RFC 8259 obsoleted RFC 7159 in December 2017. Update the json module documentation to reference the current RFC. Co-Authored-By: Claude Opus 4.5 <[email protected]>
0e2da51 to
0dbf920
Compare
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @picnixz: please review the changes made to this pull request. |
|
If my comments are not addressed (by replying to them / changing code), please don't request a review. |
Summary
Test plan
make checkpassed🤖 Generated with Claude Code
jsonmodule #136216📚 Documentation preview 📚: https://cpython-previews--144453.org.readthedocs.build/