Skip to content

Conversation

@kovan
Copy link
Contributor

@kovan kovan commented Feb 3, 2026

Summary

  • Updates JSON module documentation to reference RFC 8259 instead of RFC 7159
  • RFC 8259 obsoleted RFC 7159 in December 2017
  • Updates the errata footnote link accordingly

Test plan

  • make check passed
  • Documentation builds correctly

🤖 Generated with Claude Code


📚 Documentation preview 📚: https://cpython-previews--144453.org.readthedocs.build/

Comment on lines 707 to 709
boolean, number, or string value. :rfc:`7159` (now :rfc:`8259`) removed that
restriction, and this module does not and has never implemented that restriction
in either its serializer or its deserializer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change the flow of the text here. Reduce the diff.


.. [#rfc-errata] As noted in `the errata for RFC 7159
<https://www.rfc-editor.org/errata_search.php?rfc=7159>`_,
.. [#rfc-errata] As noted in `the errata for RFC 8259
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful here. Is it still the correct errata?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have an answer here. I'm surprised that both RFCs have the same errata.

@bedevere-app
Copy link

bedevere-app bot commented Feb 3, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

RFC 8259 obsoleted RFC 7159 in December 2017. Update the json module
documentation to reference the current RFC.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@kovan kovan force-pushed the gh-136216-json-rfc-update branch from 0e2da51 to 0dbf920 Compare February 3, 2026 23:46
@kovan
Copy link
Contributor Author

kovan commented Feb 3, 2026

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Feb 3, 2026

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from picnixz February 3, 2026 23:52
@picnixz
Copy link
Member

picnixz commented Feb 4, 2026

If my comments are not addressed (by replying to them / changing code), please don't request a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants