Skip to content

Conversation

@maxbachmann
Copy link
Contributor

@maxbachmann maxbachmann commented Feb 3, 2026

Looking through the history I was unable to find any revision where this actually did anything.

This should be a trivial enough change that it doesn't require a separate issue/news entry

@maxbachmann maxbachmann requested a review from a team as a code owner February 3, 2026 22:52
@maxbachmann
Copy link
Contributor Author

Possibly this stems from libexpat having an EXPAT_EXPORTS define in the past but that was already removed more than 20 years ago (libexpat/libexpat@5bdc756)

@picnixz picnixz changed the title remove non existent config macro Remove PYEXPAT_EXPORTS usage from PCBuild/pyexpat.vcxproj Feb 3, 2026
@picnixz
Copy link
Member

picnixz commented Feb 3, 2026

cc @hartwork

@zooba zooba added OS-windows skip issue skip news build The build process and cross-build labels Feb 3, 2026
@zooba
Copy link
Member

zooba commented Feb 3, 2026

Seems trivial to me, I don't see any uses of the variable anywhere.

@zooba zooba merged commit 9d0c743 into python:main Feb 3, 2026
55 checks passed
@hartwork
Copy link
Contributor

hartwork commented Feb 3, 2026

Throughout Expat upstream Git history, EXPAT_EXPORTS looks about as unused, I find zero code use a la "#ifdef" but only build system use:

# git log -p -G EXPAT_EXPORTS | lsdiff --strip=1 | sort -u
expat/bcb5/expat.bpr
expat/bcb5/expat.mak
expat/bcb5/expatw.bpr
expat/bcb5/expatw.mak
expat/bcb5/libexpat.bpr
expat/bcb5/libexpat.mak
expat/bcb5/libexpatw.bpr
expat/bcb5/libexpatw.mak
expat/lib/expat.dsp
expat/lib/expatw.dsp

And in CPython:

# git log -p -G PYEXPAT_EXPORTS | lsdiff --strip=1 | sort -u
PCbuild8/pyexpat/pyexpat.vcproj
PCbuild9/pyexpat.vcproj
PCbuild/pyexpat.vcproj
PCbuild/pyexpat.vcxproj
PC/VS8.0/pyexpat.vcproj
PC/VS9.0/pyexpat.vcproj

I think it's safe to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build The build process and cross-build OS-windows skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants