gh-143300: implement PyUnstable_SetImmortal#144543
Merged
kumaraditya303 merged 11 commits intopython:mainfrom Feb 11, 2026
Merged
gh-143300: implement PyUnstable_SetImmortal#144543kumaraditya303 merged 11 commits intopython:mainfrom
PyUnstable_SetImmortal#144543kumaraditya303 merged 11 commits intopython:mainfrom
Conversation
eendebakpt
reviewed
Feb 6, 2026
eendebakpt
reviewed
Feb 6, 2026
ngoldbaum
reviewed
Feb 6, 2026
Member
ZeroIntensity
left a comment
There was a problem hiding this comment.
I think we also need to document the guarantees regarding which objects may be made immortal. For example, the following results in an assertion failure:
from ctypes import pythonapi, py_object, c_int
set_immortal = pythonapi.PyUnstable_SetImmortal
set_immortal.argtypes = (py_object,)
set_immortal.restype = c_int
print(set_immortal("Hello world"))Co-authored-by: Peter Bierma <[email protected]>
Member
ZeroIntensity
left a comment
There was a problem hiding this comment.
Looks pretty good.
Bikeshedding: Should this be named PyUnstable_Object_SetImmortal? The Py[Unstable]_ prefix is generally reserved for runtime operations (though it seems PyUnstable_TryIncRef didn't follow that rule).
Contributor
Author
I'd like to keep it aligned with |
9d262b1 to
a146bef
Compare
Member
|
Kumar also added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--144543.org.readthedocs.build/