ruff #2882
Open
ruff #2882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
will need a |
…s import - Restore null=True on companies.Company contact/email/url fields to avoid unintended schema change (noqa DJ001 since removal needs migration) - Guard against None return from fix_image() in fix_success_story_images - Re-add jobs.listeners import in JobsAppConfig.ready() for signal registration - Prefix unused unpacked variables with underscore for RUF059 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nges Ruff DJ001 removed null=True from ~30 string-based model fields, but this changes the DB schema and requires migrations + data handling. Restore null=True with noqa: DJ001 to keep this as a formatting-only PR. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- cms/tests.py: add tzinfo=datetime.UTC to satisfy DTZ001, update assertion - users/apps.py: restore `import users.listeners` (signal for auth token auto-creation removed by ruff F401) - fixes all API test 401s/errors Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hugovk
reviewed
Feb 6, 2026
| @@ -0,0 +1,77 @@ | |||
| target-version = "py312" | |||
| line-length = 120 | |||
Member
There was a problem hiding this comment.
I'll leave the decision up to you, and I'm generally in favour of all this autoformatting, but I'm not a fan of very wide lines.
Sure, screens are bigger nowadays, but I find a lot of my time is spent in code reviews, with side-by-side code diffs. Longer lines means more wrapping, and harder to review diffs.
Here's a diff on my MacBook display, which can fit about 83 chars on one side of the GitHub diff UI:
When I do use a larger monitor, I tend to have two side-by-side windows, so one window with side-by-side diffs is again narrower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description