Skip to content

[experimental][ET-VK][qconv] Use specialization constants for conv2d params in q8ta shaders#18163

Open
SS-JIA wants to merge 1 commit intogh/SS-JIA/483/basefrom
gh/SS-JIA/483/head
Open

[experimental][ET-VK][qconv] Use specialization constants for conv2d params in q8ta shaders#18163
SS-JIA wants to merge 1 commit intogh/SS-JIA/483/basefrom
gh/SS-JIA/483/head

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Mar 13, 2026

Stack from ghstack (oldest at bottom):

Replace Conv2DParams UBO with specialization constants in q8ta_conv2d,
q8ta_conv2d_dw, and q8ta_im2col shaders. This allows the GPU compiler to
treat conv params (kernel size, stride, padding, dilation, groups) as
compile-time constants, enabling loop unrolling, dead code elimination,
and constant folding.

Differential Revision: D96503584

…params in q8ta shaders

Replace Conv2DParams UBO with specialization constants in q8ta_conv2d,
q8ta_conv2d_dw, and q8ta_im2col shaders. This allows the GPU compiler to
treat conv params (kernel size, stride, padding, dilation, groups) as
compile-time constants, enabling loop unrolling, dead code elimination,
and constant folding.

Differential Revision: [D96503584](https://our.internmc.facebook.com/intern/diff/D96503584/)

[ghstack-poisoned]
SS-JIA pushed a commit that referenced this pull request Mar 13, 2026
…params in q8ta shaders

Replace Conv2DParams UBO with specialization constants in q8ta_conv2d,
q8ta_conv2d_dw, and q8ta_im2col shaders. This allows the GPU compiler to
treat conv params (kernel size, stride, padding, dilation, groups) as
compile-time constants, enabling loop unrolling, dead code elimination,
and constant folding.

Differential Revision: [D96503584](https://our.internmc.facebook.com/intern/diff/D96503584/)

ghstack-source-id: 351872206
Pull Request resolved: #18163
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 13, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18163

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 8 Unrelated Failures

As of commit 92d132d with merge base cc27e6b (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant