Skip to content

FROMLIST: drm/bridge: lt9611uxc: reset edid_read on disconnect#225

Open
nlaad-qcom wants to merge 1 commit intoqualcomm-linux:qcom-6.18.yfrom
nlaad-qcom:reset_edid
Open

FROMLIST: drm/bridge: lt9611uxc: reset edid_read on disconnect#225
nlaad-qcom wants to merge 1 commit intoqualcomm-linux:qcom-6.18.yfrom
nlaad-qcom:reset_edid

Conversation

@nlaad-qcom
Copy link

@nlaad-qcom nlaad-qcom commented Feb 3, 2026

Currently edid_read has value from previous connect session and resulting in drm using older edid before new edid is available in lt9611uxc.
Reset edid_read so that correct status is updated and correct edid is available for drm.

Link: https://lore.kernel.org/lkml/[email protected]/
CR-Fixed: https://orbit/cr/4144967

Currently edid_read has value from previous connect session
and resulting in drm using older edid before new edid is available
in lt9611uxc.
Reset edid_read so that correct status is updated and correct edid
is available for drm.

Link: https://lore.kernel.org/lkml/[email protected]/T/#u
Signed-off-by: Ravi Agola <[email protected]>
Signed-off-by: Nilesh Laad <[email protected]>
rlaggysh pushed a commit to rlaggysh/kernel that referenced this pull request Feb 5, 2026
After a successful auxiliary_device_init(), aux_dev->dev.release
(xe_nvm_release_dev()) is responsible for the kfree(nvm). When
there is failure with auxiliary_device_add(), driver will call
auxiliary_device_uninit(), which call put_device(). So that the
.release callback will be triggered to free the memory associated
with the auxiliary_device.

Move the kfree(nvm) into the auxiliary_device_init() failure path
and remove the err goto path to fix below error.

"
[   13.232905] ==================================================================
[   13.232911] BUG: KASAN: double-free in xe_nvm_init+0x751/0xf10 [xe]
[   13.233112] Free of addr ffff888120635000 by task systemd-udevd/273

[   13.233120] CPU: 8 UID: 0 PID: 273 Comm: systemd-udevd Not tainted 6.19.0-rc2-lgci-xe-kernel+ qualcomm-linux#225 PREEMPT(voluntary)
...
[   13.233125] Call Trace:
[   13.233126]  <TASK>
[   13.233127]  dump_stack_lvl+0x7f/0xc0
[   13.233132]  print_report+0xce/0x610
[   13.233136]  ? kasan_complete_mode_report_info+0x5d/0x1e0
[   13.233139]  ? xe_nvm_init+0x751/0xf10 [xe]
...
"

v2: drop err goto path. (Alexander)

Fixes: 7926ba2 ("drm/xe: defer free of NVM auxiliary container to device release callback")
Reviewed-by: Nitin Gote <[email protected]>
Reviewed-by: Brian Nguyen <[email protected]>
Cc: Alexander Usyskin <[email protected]>
Cc: Rodrigo Vivi <[email protected]>
Suggested-by: Brian Nguyen <[email protected]>
Signed-off-by: Shuicheng Lin <[email protected]>
Signed-off-by: Ashutosh Dixit <[email protected]>
Link: https://patch.msgid.link/[email protected]
(cherry picked from commit a3187c0)
Signed-off-by: Thomas Hellström <[email protected]>
@shashim-quic
Copy link

Currently edid_read has value from previous connect session and resulting in drm using older edid before new edid is available in lt9611uxc. Reset edid_read so that correct status is updated and correct edid is available for drm.

Link: https://lore.kernel.org/lkml/[email protected]/

Pls add CRs-Fixed: to PR description.

svankas pushed a commit to svankas/kernel that referenced this pull request Feb 16, 2026
[ Upstream commit 8a44241 ]

After a successful auxiliary_device_init(), aux_dev->dev.release
(xe_nvm_release_dev()) is responsible for the kfree(nvm). When
there is failure with auxiliary_device_add(), driver will call
auxiliary_device_uninit(), which call put_device(). So that the
.release callback will be triggered to free the memory associated
with the auxiliary_device.

Move the kfree(nvm) into the auxiliary_device_init() failure path
and remove the err goto path to fix below error.

"
[   13.232905] ==================================================================
[   13.232911] BUG: KASAN: double-free in xe_nvm_init+0x751/0xf10 [xe]
[   13.233112] Free of addr ffff888120635000 by task systemd-udevd/273

[   13.233120] CPU: 8 UID: 0 PID: 273 Comm: systemd-udevd Not tainted 6.19.0-rc2-lgci-xe-kernel+ qualcomm-linux#225 PREEMPT(voluntary)
...
[   13.233125] Call Trace:
[   13.233126]  <TASK>
[   13.233127]  dump_stack_lvl+0x7f/0xc0
[   13.233132]  print_report+0xce/0x610
[   13.233136]  ? kasan_complete_mode_report_info+0x5d/0x1e0
[   13.233139]  ? xe_nvm_init+0x751/0xf10 [xe]
...
"

v2: drop err goto path. (Alexander)

Fixes: 7926ba2 ("drm/xe: defer free of NVM auxiliary container to device release callback")
Reviewed-by: Nitin Gote <[email protected]>
Reviewed-by: Brian Nguyen <[email protected]>
Cc: Alexander Usyskin <[email protected]>
Cc: Rodrigo Vivi <[email protected]>
Suggested-by: Brian Nguyen <[email protected]>
Signed-off-by: Shuicheng Lin <[email protected]>
Signed-off-by: Ashutosh Dixit <[email protected]>
Link: https://patch.msgid.link/[email protected]
(cherry picked from commit a3187c0)
Signed-off-by: Thomas Hellström <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments