media: pisp_be: Add support for the NV12MT_10_COL128 format#7227
Merged
pelwell merged 1 commit intoraspberrypi:rpi-6.18.yfrom Feb 6, 2026
Merged
media: pisp_be: Add support for the NV12MT_10_COL128 format#7227pelwell merged 1 commit intoraspberrypi:rpi-6.18.yfrom
pelwell merged 1 commit intoraspberrypi:rpi-6.18.yfrom
Conversation
The 10bit column format from the HEVC codec is supported by the PISP BE, so add the configuration. It requires some additional handling as it packs 3 10bit samples into 32 bits, with 2 bits of padding. Alignment and calculating strides is therefore not quite as straightforward. Signed-off-by: Dave Stevenson <[email protected]>
naushir
reviewed
Feb 6, 2026
| */ | ||
| const unsigned int align = | ||
| p->bytesperline ? fmt->min_align : fmt->opt_align; | ||
| unsigned int pixel_grouping = fmt->pixel_grouping ?: 1; |
Contributor
There was a problem hiding this comment.
Will this type of statement be accepted upstream? It does the right thing with gcc, but is not standard C syntax.
Contributor
There was a problem hiding this comment.
Although there seems to be tons of this type of usage in other kernel source files.
Contributor
There was a problem hiding this comment.
Must be getting rusty - never seen that syntax before, had to look it up!
Collaborator
There was a problem hiding this comment.
Technically it is not C code. It's a gcc extension (that clang also supports).
But the kernel allows many gcc extensions and this idiom is commonly used.
naushir
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 10bit column format from the HEVC codec is supported by the PISP BE, so add the configuration.
It requires some additional handling as it packs 3 10bit samples into 32 bits, with 2 bits of padding. Alignment and calculating strides is therefore not quite as straightforward.