Open
Conversation
Comment on lines
+131
to
+133
| SETCONFIGVALUE(AAMP_CUSTOM_DEV_CFG_SETTING, eAAMPConfig_useRialtoSink, false); | ||
| PlayerLogManager::SetLoggerInfo(AampLogManager::disableLogRedirection, gpGlobalConfig->IsConfigSet(eAAMPConfig_useRialtoSink), AampLogManager::aampLoglevel, AampLogManager::locked); | ||
|
|
||
| SETCONFIGVALUE(AAMP_CUSTOM_DEV_CFG_SETTING, eAAMPConfig_useRialtoSink, false); |
There was a problem hiding this comment.
These two SETCONFIGVALUE(AAMP_CUSTOM_DEV_CFG_SETTING, eAAMPConfig_useRialtoSink, false) calls (a) duplicate each other and (b) force useRialtoSink off at the highest-priority config owner, overriding any value loaded from config files/env or set by the application. This likely breaks Rialto-sink enablement and logging redirection logic. Remove the duplicate, and avoid overriding the loaded config here unless there is a platform-gated reason (in which case apply it conditionally and/or at a lower priority).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.