feat: change types into React.Key of tabs props#653
Open
Lantianyou wants to merge 1 commit intoreact-component:masterfrom
Open
feat: change types into React.Key of tabs props#653Lantianyou wants to merge 1 commit intoreact-component:masterfrom
Lantianyou wants to merge 1 commit intoreact-component:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 17 17
Lines 622 622
Branches 165 165
=======================================
Hits 610 610
Misses 12 12 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMO, the
keytype will make more sense as React.Key. Since I have not read the codebase throughly, maybe thekeyis string for a reason. If so, feel free to close this PR.