Update PHPStan

[ondrejmirtes]

PHPStan 1.10.31 introduces NonAcceptingNeverType (phpstan/phpstan#6485, phpstan/phpstan#9133) that ensures that a literal never type in the code does not accept any other type except never.

As a side-effect of this change a type description or an error message about this changed from *NEVER* to never. I'm sending an update to your test suite because of this :)

[clue]

@ondrejmirtes Thank you for looking into this and suggesting improvements for the work done in #247. Briefly eyeballed your changes and noticed there are still a couple of *NEVER* types in tests/types/resolve.php, can you help me understand the reason for what currently looks like an inconsistency?

[ondrejmirtes]

The code in question:

assertType('React\Promise\PromiseInterface<*NEVER*>', resolve(true)->then(function (bool $value): never {
    throw new \RuntimeException();
}));

There are two "never" types in PHPStan:

• NeverType (*NEVER*) - used basically everywhere - in cases like empty arrays
• NonAcceptingNeverType (never) - used when the user types never literally in PHPDoc or native return type

For anonymous functions, PHPStan can infer always-throwing function even without a native never return type. In that case, *NEVER* is used. But there's probably isn't a good reason for that, so I changed it: phpstan/phpstan-src@3e03e9d

It will be released at the earliest convenience.

[clue]

@ondrejmirtes Thanks for the insights and the update in PHPStan! 👍

Your explanation sounds reasonable. It's my understanding this is more of a maintenance topic that doesn't currently have high priority, so we probably want to keep this open until the next PHPStan is released and we can update this consistently in a single shot. Thank you, will keep an eye on this!

[WyriHaximus]

Thanks @ondrejmirtes for filing this, had a quick row with this while working on the initial templates implementation. Liking these changes 👍 .

[ondrejmirtes]

Just update PHPStan version and all *NEVER* to never. This should be good to go :)

[SimonFrings]

👍

[clue]

@ondrejmirtes Thanks for the update, changes LGTM!