Cast Sequence to list on assignment (with templates)

[InvincibleRMC]

Description

With templates

My proposal on what the solution for The Sequence Api discussion.
Zulip discussion here.

Is this user-facing behavior change?

Yes in the past users type would only change on receiving from a subscriber but, now the change is done on assignment to be more inline with numpy.array and array.array casts.

Did you use Generative AI?

Additional Information

[InvincibleRMC]

@christophebedard here is an implementation with straight templates. The only jankness comes not being able to apply indents to templates nicely. If there is some cleaner way I would love to know. Trying to use the empy documentation was trying.

[InvincibleRMC]

Pulls: #249
Gist: https://gist.githubusercontent.com/InvincibleRMC/92aa793f18157212d6b107cf5bb51435/raw/fed5b0c61dd10d8e464ffc8711c11964bb7461ca/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18129

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

Pulls: #249
Gist: https://gist.githubusercontent.com/InvincibleRMC/eb456bb5d936910bdad666e94a74882c/raw/fed5b0c61dd10d8e464ffc8711c11964bb7461ca/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18136

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

@christophebedard does this templated solution work for you?

[InvincibleRMC]

Pulls: #249
Gist: https://gist.githubusercontent.com/InvincibleRMC/b0c3076a986b5ed3385f650072dbb017/raw/fed5b0c61dd10d8e464ffc8711c11964bb7461ca/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18226

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

Pulls: #249
Gist: https://gist.githubusercontent.com/InvincibleRMC/f009723ba7dbc9651448212d430a3eed/raw/fed5b0c61dd10d8e464ffc8711c11964bb7461ca/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18227

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[christophebedard]

I'm reviewing this now. Just to make sure I understand, this replaces #247 and #246.

Can you summarize the discussion we had on Zulip/in PMC meetings in the PR description?

[christophebedard]

Some comments and suggestions. I really had to look at the output, because this is just so 😵

[InvincibleRMC]

Pulls: #249
Gist: https://gist.githubusercontent.com/InvincibleRMC/5250b2325d47ef516b09d556af3f9ca3/raw/fed5b0c61dd10d8e464ffc8711c11964bb7461ca/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18340

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

Hmmm. Pytest seems to be missing in this rhel job? It also has happend in my last 3 rhel CI jobs across repos. But others seem fine. I'll rerun but, 3 for 3 is sus.

[InvincibleRMC]

Pulls: #249
Gist: https://gist.githubusercontent.com/InvincibleRMC/a381ef6dd88d17c5d393f2b1c580bef7/raw/fed5b0c61dd10d8e464ffc8711c11964bb7461ca/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18341

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[christophebedard]

LGTM with green CI. We'll have to wait for ros2/launch#944 to be fixed

[InvincibleRMC]

LGTM with green CI. We'll have to wait for ros2/launch#944 to be fixed

I have a fear that the launch stuff might be unrelated. Since it cant find pytest at all which shouldn't be in any way related but, will re-run stuff after a fix is merged.

[christophebedard]

Where are you saying that error about pytest? It's not very clear if you just click on the test failures in the list under the CI job page, but all test failures are basically this:

11:29:37   File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/install/launch/lib/python3.9/site-packages/launch/actions/declare_boolean_launch_argument.py", line 60, in DeclareBooleanLaunchArgument
11:29:37     default_value: Optional[SomeSubstitutionsType | bool] = None,
11:29:37 TypeError: unsupported operand type(s) for |: '_UnionGenericAlias' and 'type'

[InvincibleRMC]

Its being hidden within the launch stuff but looking at several packages I'm seeing the following.

From rosbag2_py console log for example

CMake Warning at /home/jenkins-agent/workspace/ci_linux-rhel/ws/install/ament_cmake_pytest/share/ament_cmake_pytest/cmake/ament_add_pytest_test.cmake:82 (message):
02:09:47   The Python module 'pytest' was not found, pytests cannot be run.  On Linux,
02:09:47   install the 'python3-pytest' package.  On other platforms, install 'pytest'
02:09:47   using pip.
02:09:47 Call Stack (most recent call first):
02:09:47   CMakeLists.txt:190 (ament_add_pytest_test

[christophebedard]

ah! So some tests are just not getting run. There may be an issue with the way we detect pytest: https://github.com/ament/ament_cmake/blob/d4781cd07fd083c202feeaf1bfa5ddec860d5120/ament_cmake_pytest/cmake/ament_has_pytest.cmake#L40-L47

[InvincibleRMC]

ah! So some tests are just not getting run. There may be an issue with the way we detect pytest: https://github.com/ament/ament_cmake/blob/d4781cd07fd083c202feeaf1bfa5ddec860d5120/ament_cmake_pytest/cmake/ament_has_pytest.cmake#L40-L47

But like the last edit was 5 years ago? And it only started it like 1 or 2 days ago in job #7968. And its still in ros2/ci for rhel.

[christophebedard]

I believe we've had issues with finding or getting the right Python interpreter in the past on RHEL. Maybe something changed? I know Humble/RHEL 8 needed an explicit -DPYTHON_EXECUTABLE=... CMake arg. We should start by opening an issue under github.com/ros2/ci

[InvincibleRMC]

I believe we've had issues with finding or getting the right Python interpreter in the past on RHEL. Maybe something changed? I know Humble/RHEL 8 needed an explicit -DPYTHON_EXECUTABLE=... CMake arg. We should start by opening an issue under github.com/ros2/ci

Ok. The pytest stuff did also effect the nightly. But it was fine just the day prior.

[InvincibleRMC]

Pulls: #249
Gist: https://gist.githubusercontent.com/InvincibleRMC/6196f11c483ca331d7726cfa02c51c83/raw/fed5b0c61dd10d8e464ffc8711c11964bb7461ca/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18346

• Linux
• Linux-aarch64
• Linux-rhel
• Windows

[InvincibleRMC]

Pulls: #249
Gist: https://gist.githubusercontent.com/InvincibleRMC/3c5f98d23db92cffeb34684454a0406a/raw/fed5b0c61dd10d8e464ffc8711c11964bb7461ca/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rosidl_generator_py
TEST args: --packages-above rosidl_generator_py
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18353

• Linux
• Linux-aarch64
• Linux-rhel
• Windows