Conversation
|
@hsbt, I've requested a review from you because you're the frequent contributor in recent history. Let me know if you'd like me to request someone else. |
|
@hsbt, should I ask someone else to review? |
|
@hsbt, I think this is ready for review. |
olleolleolle
left a comment
There was a problem hiding this comment.
I like this change, in that it strengthens the "general section" which provides a complete narrative, for the learner/reader.
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
olleolleolle
left a comment
There was a problem hiding this comment.
Looks ✨ good ✨ to me!
|
@hsbt, @olleolleolle has reviewed and approved this PR. Ok to merge? I'm reluctant without hearing from you. |
|
@tenderlove, would appreciate a blessing from you or @hsbt before merging this. |
|
@BurdetteLamar You ignored our feedback at ruby/ruby#3506 (comment) Because I couldn't/will not approve your pull-request. |
|
@tenderlove, you are a maintainer here? Can you (or someone) review this? |
This PR concerns primarily the high-level interface:
This PR is larger than I would have liked, but the high-level API concepts are intertwined, and the their doc needs to be modified all at once.