Fix: media element w/o duration would overwrite enclosure's length#11
Fix: media element w/o duration would overwrite enclosure's length#11onli wants to merge 1 commit intorubycocos:masterfrom
Conversation
|
thanks for the fix & update. i try to merge this summer (july / august). can you post the link to the podcast rss feed by any chance? i'd like to add as a test case. all (feedparser) tests are here -> https://github.com/rubycocos/feedparser/tree/master/feeds |
|
I will ask the user about the status of the feed link, whether it's private or not. |
|
It's a public feed, this one: https://www.omnycontent.com/d/playlist/e73c998e-6e60-432f-8610-ae210140c5b1/A91018A4-EA4F-4130-BF55-AE270180C327/44710ECC-10BB-48D1-93C7-AE270180C33E/podcast.rss Note that I also tried to parse it with just ruby's rss module and that failed because of some invalid itunes tag, so there might be some additional surprises in there. |
|
thanks for the web feed link. i try to have a look later this summer. thks for your patience. |
I stumbled over a podcast feed that had both an enclosure and a media:content element, but the media element had no duration set. Feedparser would end up with an attachment that had a size element set to nil. That's problematic, especially since ruby's rss lib will not create the enclosure element without a length element (it is required by spec).