Fix short backtraces from stripped executables #151740
Open
+184
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
bjorn3
reviewed
Jan 27, 2026
This comment has been minimized.
This comment has been minimized.
eggyal
force-pushed
the
short-backtrace-markers-by-addr
branch
from
53c0426 to
f857f07
Compare
This comment has been minimized.
This comment has been minimized.
eggyal
force-pushed
the
short-backtrace-markers-by-addr
branch
from
f857f07 to
6605497
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
Member
|
@rustbot reroll |
joboet
requested changes
Jan 30, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Locate the beginning and ending frames for short backtraces by address in addition to symbol name, so that they work even when symbols have been stripped from the executable. We need to retain matching by symbol name for the time being, because rustc (and some associated ui tests) rely upon it to have ICE backtraces abbreviated. They can be updated once this commit lands in beta/stage0.
eggyal
force-pushed
the
short-backtrace-markers-by-addr
branch
from
c650ea2 to
6c5d59a
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
eggyal
force-pushed
the
short-backtrace-markers-by-addr
branch
from
6c5d59a to
827da1d
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@rustbot author |
rustbot
added
S-waiting-on-author
The new short backtrace markers place three frames in backtraces: the marker initially invoked by downstream code (should be inlined into such downstream code); the type-erased marker at a known-address (detected by the backtrace printing code); and the type-restoring callback shim (into which the actual callback should also be inlined). This differs from the status-quo ante, where the backtrace markers placed only a single frame into backtraces. Whilst these additional frames should have negligible impact on runtime performance (not only are they called, by the language runtime, at most twice: once during start before invoking main and once upon panic, if any; but furthermore, due to the aforementioned inlining, optimized assembly should be very similar - the additional frames will mostly only arise from additional debug info), the expected outputs from some miri tests require updating to reflect these backtrace changes.
This status-quo ante of this naked function test defined a label with the symbolic name `.L7`. However, changes to the stack could cause a collision with that same symbolic name being defined by compiler- generated code; therefore we use a local label instead to guarantee collision avoidance.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locate the beginning and ending frames for short backtraces by address in addition to symbol name, so that they work even when symbols have been stripped from the executable.
We need to retain matching by symbol name for the time being, because rustc (and some associated ui tests) rely upon it to have ICE backtraces abbreviated. They can be updated once this commit lands in beta/stage0. (It is for this reason that the begin/end methods are being publicly exported from
std::backtrace, albeit hidden from documentation and marked unstable).Fixes #147846
r? libs