Make the entire crate compatible with the array reference type#109
Merged
akern40 merged 7 commits intorust-ndarray:masterfrom Dec 24, 2025
Merged
Make the entire crate compatible with the array reference type#109akern40 merged 7 commits intorust-ndarray:masterfrom
akern40 merged 7 commits intorust-ndarray:masterfrom
Conversation
nilgoyette
approved these changes
Nov 6, 2025
Contributor
nilgoyette
left a comment
There was a problem hiding this comment.
Interesting to see that the new ndarray makes most generic functions declaration less verbose. I mean, you already knew, but it's great to see it :)
Contributor
Author
|
Oh believe me it was satisfying! Just finished this same process for |
a27fe70 to
185e37f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is large, but is repetitive and contains all of the code necessary to make
ndarray-statscompatible withndarray0.17. It does the following:ndarrayto 0.17.1ndarray-randto 0.16.0ArrayRefinstead ofArrayBaseArrayBase