Skip to content

Conversation

@ntkme
Copy link
Contributor

@ntkme ntkme commented Jan 26, 2026

@ntkme
Copy link
Contributor Author

ntkme commented Jan 26, 2026

There is a weird ts-jest bug that prevents the test to run on node 20. Otherwise this works fine. Compiled JS code also works fine on node 20 in the js-api-spec test.

@nex3 nex3 mentioned this pull request Jan 28, 2026
3 tasks
@ntkme
Copy link
Contributor Author

ntkme commented Jan 29, 2026

@nex3 I fixed other things you pointed out expect the node/typescript/ts-jest compatibility issue. I think one solution is to just compile all test to JS and run plain jest without ts-jest.

@Goodwine What was your other workaround for the color.js 6 typescript import issue? I'm curious because at this point maybe that's actually a better solution.

@Goodwine
Copy link
Member

@ntkme I added the following to tsconfig.json:

"paths": {
  "colorjs.io": "node_modules/colorjs.io/...something.../types.d.ts"
}

@ntkme
Copy link
Contributor Author

ntkme commented Jan 30, 2026

Basically I used a freshly cloned repo and tried adding the following under "compilerOptions". None of these worked:

    "paths": {
      "colorjs.io": "node_modules/colorjs.io/types/src/types.d.ts"
    }
    "paths": {
      "colorjs.io": "node_modules/colorjs.io/types/src/index.d.ts"
    }
    "paths": {
      "colorjs.io": "node_modules/colorjs.io/types/index.d.ts"
    }

@Goodwine Am I missing something, or maybe you're running an older version of node, typescript, ts-jest, or jest?

dependabot bot and others added 7 commits January 29, 2026 16:53
Bumps [colorjs.io](https://github.com/color-js/color.js) from 0.5.2 to 0.6.1.
- [Release notes](https://github.com/color-js/color.js/releases)
- [Commits](color-js/color.js@v0.5.2...v0.6.1)

---
updated-dependencies:
- dependency-name: colorjs.io
  dependency-version: 0.6.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@ntkme
Copy link
Contributor Author

ntkme commented Jan 30, 2026

Basically I'm keep hitting this color-js/color.js#707 unless I apply the module and moduleResolution changes suggested in that issue.

@ntkme
Copy link
Contributor Author

ntkme commented Jan 30, 2026

@ntkme ntkme force-pushed the rec2020-2.4-gamma branch 2 times, most recently from 864fa45 to 0b66e4d Compare January 30, 2026 01:57
@ntkme ntkme requested a review from nex3 January 30, 2026 01:58
@ntkme ntkme marked this pull request as ready for review January 30, 2026 01:58
@ntkme ntkme force-pushed the rec2020-2.4-gamma branch from 0b66e4d to f5e37c8 Compare January 30, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use gamma 2.40 for rec2020

3 participants