Optimize detonation range and detonation radius checks#7281
Open
Kestrellius wants to merge 2 commits intoscp-fs2open:masterfrom
Open
Optimize detonation range and detonation radius checks#7281Kestrellius wants to merge 2 commits intoscp-fs2open:masterfrom
Kestrellius wants to merge 2 commits intoscp-fs2open:masterfrom
Conversation
wookieejedi
requested changes
Mar 12, 2026
wookieejedi
added
the
optimization
wookieejedi
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we're checking whether a weapon is past its det range or has a target within det radius, all we need to know is whether the value is smaller or larger, so we can skip the expensive square root.
At some point I should comb through all the instances of
vm_vec_dist(andvm_vec_mag) and find all the ones to which this optimization can be applied, because I would guess there are quite a few, but detonation radius is the one I have a short-term use case for, so for now I've just done that one (and detonation range, since it was right there).