docs: fix typos and improve comments in EventUpdateLogic#1784
docs: fix typos and improve comments in EventUpdateLogic#1784Olexandr88 wants to merge 1 commit intoscroll-tech:developfrom
Conversation
📝 WalkthroughWalkthroughDocumentation comments in the event update logic module were revised for precision: descriptions for the EventUpdateLogic struct, its constructor, and methods GetL1SyncHeight and UpdateL2BridgeBatchDepositEvent were clarified. No code behavior or public signatures were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@bridge-history-api/internal/logic/event_update.go`:
- Line 53: Update the function comment for GetL1SyncHeight to accurately
describe that it returns three separate L1 sync heights: the message synced
height, the batch synced height, and the bridge batch deposit synced height;
mention each returned value by name (message synced height, batch synced height,
bridge batch deposit synced height) so callers know what the three return values
represent and in what order.
| } | ||
|
|
||
| // GetL1SyncHeight gets the l1 sync height from db | ||
| // GetL1SyncHeight returns the L1 sync height from the database. |
There was a problem hiding this comment.
Clarify that the method returns three sync heights.
The comment states "returns the L1 sync height" (singular), but the function actually returns three distinct sync heights: message synced height, batch synced height, and bridge batch deposit synced height.
📝 Suggested improvement
-// GetL1SyncHeight returns the L1 sync height from the database.
+// GetL1SyncHeight returns the L1 message, batch, and bridge batch deposit sync heights from the database.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| // GetL1SyncHeight returns the L1 sync height from the database. | |
| // GetL1SyncHeight returns the L1 message, batch, and bridge batch deposit sync heights from the database. |
🤖 Prompt for AI Agents
In `@bridge-history-api/internal/logic/event_update.go` at line 53, Update the
function comment for GetL1SyncHeight to accurately describe that it returns
three separate L1 sync heights: the message synced height, the batch synced
height, and the bridge batch deposit synced height; mention each returned value
by name (message synced height, batch synced height, bridge batch deposit synced
height) so callers know what the three return values represent and in what
order.
|
Thanks. We currently do not accept typo fix and comment update PRs. |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.