fix(connectors): align connector scopes with oauth config and fix kb modal UX#3573
fix(connectors): align connector scopes with oauth config and fix kb modal UX#3573waleedlatif1 merged 7 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Updates multiple connector configs to use the new selector fields (e.g., Airtable base/table cascade, Jira/Confluence space/project, Slack channel, etc.), and fixes auth mismatches by adjusting OAuth Also includes small UI/docs tweaks: modal sizing/scroll behavior, API key input masking only when blurred, fix tag checkbox click handling, remove duplicate “Connected Sources” heading, change navbar Docs link to external, simplify docs-site Written by Cursor Bugbot for commit b4cd61a. Configure here. |
Greptile SummaryThis PR fixes OAuth scope mismatches that were causing false "Additional permissions required" warnings for Gmail, Google Sheets, and Google Calendar connectors, adds missing The connector scope fixes correctly align Key changes:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant UI as ConnectorCard (UI)
participant CR as CONNECTOR_REGISTRY
participant OC as useOAuthCredentials
participant Utils as getMissingRequiredScopes
UI->>CR: Look up connectorDef by connectorType
CR-->>UI: connectorDef (auth.requiredScopes)
UI->>OC: fetch credentials for providerId
OC-->>UI: credentials[]
UI->>Utils: getMissingRequiredScopes(credential, requiredScopes)
Note over Utils: Exact string match of requiredScopes<br/>against credential.grantedScopes
Utils-->>UI: missingScopes[]
alt missingScopes.length > 0
UI->>UI: Show "Additional permissions required" banner
UI->>UI: Open OAuthRequiredModal on click
else No missing scopes
UI->>UI: Normal connector card (no banner)
end
|
...orkspace/[workspaceId]/knowledge/[id]/components/add-connector-modal/add-connector-modal.tsx
Show resolved
Hide resolved
…onfig Replace manual ID text inputs with dynamic selector dropdowns that fetch options from the existing selector registry. Users can toggle between selector and manual input via canonical pairs (basic/advanced mode). Adds selector support to 12 connectors: Airtable (cascading base→table), Slack, Gmail, Google Calendar, Linear (cascading team→project), Jira, Confluence, MS Teams (cascading team→channel), Notion, Asana, Webflow, and Outlook. Dependency clearing propagates across canonical siblings to prevent stale cross-mode data on submit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@greptile |
|
@cursor review |
...orkspace/[workspaceId]/knowledge/[id]/components/add-connector-modal/add-connector-modal.tsx
Show resolved
Hide resolved
...aceId]/knowledge/[id]/components/add-connector-modal/components/connector-selector-field.tsx
Show resolved
Hide resolved
...orkspace/[workspaceId]/knowledge/[id]/components/add-connector-modal/add-connector-modal.tsx
Show resolved
Hide resolved
...orkspace/[workspaceId]/knowledge/[id]/components/add-connector-modal/add-connector-modal.tsx
Show resolved
Hide resolved
...aceId]/knowledge/[id]/components/add-connector-modal/components/connector-selector-field.tsx
Outdated
Show resolved
Hide resolved
…ctive mode values Fixes three issues from PR review: - Dependency clearing now includes canonical siblings of dependent fields (e.g., changing base clears both tableSelector AND tableIdOrName) - Selector context and depsResolved now resolve dependency values through the active canonical mode, not just the raw depFieldId - Tooltip text changed from "Switch to manual ID" to "Switch to manual input" to correctly describe dropdown fallbacks (e.g., Outlook folder) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
...aceId]/knowledge/[id]/components/add-connector-modal/components/connector-selector-field.tsx
Show resolved
Hide resolved
...orkspace/[workspaceId]/knowledge/[id]/components/add-connector-modal/add-connector-modal.tsx
Show resolved
Hide resolved
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Summary
requiredScopesfor Reddit connectorType of Change
Testing
Tested manually
Checklist