This repository was archived by the owner on Aug 15, 2022. It is now read-only.
Implement passing configuration over environment variables#93
Open
kpaleniu wants to merge 4 commits intoslack-samples:masterfrom
Open
Implement passing configuration over environment variables#93kpaleniu wants to merge 4 commits intoslack-samples:masterfrom
kpaleniu wants to merge 4 commits intoslack-samples:masterfrom
Conversation
|
Hi. What is the ETA for merging the change? |
|
@Roach I think this should be merged. Having config in env vars is critical when running rtmbot in containers and/or kubernetes. |
fzipi
pushed a commit
to Perceptyx/python-rtmbot
that referenced
this pull request
Nov 22, 2018
fzipi
added a commit
to Perceptyx/python-rtmbot
that referenced
this pull request
Nov 22, 2018
Add patch slack-samples#93 from upstream
|
@Roach could you merge this please - from the Perceptyx version I saw it also seemed to incorporate allowing the log to be set to STDOUT - which is also crucial. Containers don't like log-files - the environments are ephemeral, but typically have good logging of stdout etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request adds functionality for overriding configuration file content from environment variables.
For example:
This will result in effectively the following
rtmbot.conf:All rtmbot-specific configuration variables can overridden. For plugin-specific configuration
I left the limitation of treating all values as strings to keep code from getting overly complex.
All this is mentioned in the
README.mdthat is also updated by this pull request.Related Issues
Implements at least the environment variable portion of #89.
Test strategy
tests/test_rtmbot_runner.pyincludes unit tests that cover most usual cases that came to mind.