Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 14 14
Lines 2697 2697
=======================================
Hits 2587 2587
Misses 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Member
Author
|
A few CLI fixes were needed for |
Comment on lines
+257
to
+259
| - ubuntu-latest | ||
| - macos-latest | ||
| - windows-latest |
Comment on lines
+46
to
+54
| - name: Add Slack CLI to PATH | ||
| if: steps.slack-cli-check.outputs.exists != 'true' && runner.os != 'Windows' | ||
| shell: bash | ||
| run: echo "$HOME/.slack/bin" >> "$GITHUB_PATH" # zizmor: ignore[github-env] | ||
|
|
||
| - name: Add Slack CLI to PATH | ||
| if: steps.slack-cli-check.outputs.exists != 'true' && runner.os == 'Windows' | ||
| shell: pwsh | ||
| run: Add-Content -Path $env:GITHUB_PATH -Value "$env:USERPROFILE\AppData\Local\slack-cli\bin" # zizmor: ignore[github-env] |
| env: | ||
| SLACK_CLI_VERSION: ${{ inputs.version }} | ||
|
|
||
| - name: Install Slack CLI |
Contributor
There was a problem hiding this comment.
Nit
Suggested change
| - name: Install Slack CLI | |
| - name: Pwsh Install Slack CLI |
| shell: pwsh | ||
| run: Add-Content -Path $env:GITHUB_PATH -Value "$env:USERPROFILE\AppData\Local\slack-cli\bin" # zizmor: ignore[github-env] | ||
|
|
||
| - name: Install Slack CLI |
Contributor
There was a problem hiding this comment.
Nit
Suggested change
| - name: Install Slack CLI | |
| - name: Bash Install Slack CLI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for running Slack CLI commands with this composite action:
Follows earlier efforts and explorations of @ewanek1 in #484 #486 #488 #489 👾 ✨
Notes
Requirements