[SofaPython3] Add in DataHelper dedicated to-string conversion from basedata#189
Merged
fredroy merged 1 commit intosofa-framework:masterfrom Sep 23, 2021
Conversation
…ata field to increase compatibility with SofaPython(2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SofaPython it was possible do write:
node.createObject("MechanicalObejct", position=loader.position)
This was working as loader.position was returning the values of the data field.
In SofaPython3 ithis will fails as loader.position is not returning anymore the values but the data:
node.createObject("MechanicalObejct", position=loader.position)
Object creation is still using a systematic to-string conversion (see PR #45), so the data are converted to string using the "repr" operator which does not necesserly generate a sofa-compatible string.
When the object to convert is a BaseData... it is much better to rely on the getValueString() fonction which returns a string compatible with sofa.