test(v2): add vite-ecosystem-ci scripts#2076
Merged
birkskyum merged 9 commits intosolidjs:mainfrom Feb 23, 2026
Merged
Conversation
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
brenelz
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards
This PR contains:
Ecosystem CI Integration: Added
vite-ecosystem-ciscripts to the rootpackage.json. They'll be called from the vite-ecosystem-ci workflows which will inject vite v8 as a pnpm override.Playwright Port Stability: Fixed intermittent Playwright test timeouts in
apps/testsby explicitly binding the Vite dev server to--host 127.0.0.1and adding--strictPorton port3000. This lets Playwright fail fast rather than quietly shifting ports and hanging.Testing:
First with vite 7, run
pnpm install,pnpm run vite-ecosystem-ci:buildandpnpm run vite-ecosystem-ci:testThen add into root package.json the following:
And now with vite 8 run the same
pnpm install,pnpm run vite-ecosystem-ci:buildandpnpm run vite-ecosystem-ci:testgo into the nitro-v3 fixture and run the dev server
What is the current behavior?
Crashes in the manifest plugin with Vite 8
What is the new behavior?
All builds and tests passing