Skip to content

test(v2): add vite-ecosystem-ci scripts#2076

Merged
birkskyum merged 9 commits intosolidjs:mainfrom
birkskyum:vite-ecosystem-ci
Feb 23, 2026
Merged

test(v2): add vite-ecosystem-ci scripts#2076
birkskyum merged 9 commits intosolidjs:mainfrom
birkskyum:vite-ecosystem-ci

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Feb 22, 2026

Towards

This PR contains:

  • Ecosystem CI Integration: Added vite-ecosystem-ci scripts to the root package.json. They'll be called from the vite-ecosystem-ci workflows which will inject vite v8 as a pnpm override.

  • Playwright Port Stability: Fixed intermittent Playwright test timeouts in apps/tests by explicitly binding the Vite dev server to --host 127.0.0.1 and adding --strictPort on port 3000. This lets Playwright fail fast rather than quietly shifting ports and hanging.

Testing:

First with vite 7, run

pnpm install, pnpm run vite-ecosystem-ci:build and pnpm run vite-ecosystem-ci:test

Then add into root package.json the following:

  "pnpm": {
    "overrides": {
      "vite": "8.0.0-beta.15"
    }
  }

And now with vite 8 run the same

pnpm install, pnpm run vite-ecosystem-ci:build and pnpm run vite-ecosystem-ci:test

go into the nitro-v3 fixture and run the dev server

What is the current behavior?

Crashes in the manifest plugin with Vite 8

What is the new behavior?

All builds and tests passing

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2026

⚠️ No Changeset found

Latest commit: 0587c21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 22, 2026

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 0587c21
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/699ce2d09583410008b9faf2
😎 Deploy Preview https://deploy-preview-2076--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 22, 2026

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2076
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2076

commit: 0587c21

@birkskyum birkskyum marked this pull request as draft February 22, 2026 20:31
@birkskyum birkskyum marked this pull request as ready for review February 22, 2026 20:37
@birkskyum birkskyum changed the title Add vite-ecosystem-ci scripts and Vite 8 support Add vite-ecosystem-ci scripts Feb 22, 2026
@birkskyum birkskyum changed the title Add vite-ecosystem-ci scripts tests: add vite-ecosystem-ci scripts Feb 22, 2026
@birkskyum birkskyum changed the title tests: add vite-ecosystem-ci scripts test: add vite-ecosystem-ci scripts Feb 22, 2026
@birkskyum birkskyum changed the title test: add vite-ecosystem-ci scripts test(v2): add vite-ecosystem-ci scripts Feb 23, 2026
@birkskyum birkskyum merged commit 5e17472 into solidjs:main Feb 23, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants