Skip to content

Comments

refactor: use pnpm workspace for local packages#2077

Open
birkskyum wants to merge 2 commits intosolidjs:mainfrom
birkskyum:use-pnpm-overrides-for-workspace-packages
Open

refactor: use pnpm workspace for local packages#2077
birkskyum wants to merge 2 commits intosolidjs:mainfrom
birkskyum:use-pnpm-overrides-for-workspace-packages

Conversation

@birkskyum
Copy link
Member

@birkskyum birkskyum commented Feb 22, 2026

Instead of relative paths for the start and nitro v2 plugin packages, we can just use the pnpm workspace.

Depends on

@netlify
Copy link

netlify bot commented Feb 22, 2026

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit b3594a6
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/699bb79389002200087c4a78
😎 Deploy Preview https://deploy-preview-2077--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2026

⚠️ No Changeset found

Latest commit: b3594a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 22, 2026

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2077
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2077

commit: b3594a6

@birkskyum birkskyum force-pushed the use-pnpm-overrides-for-workspace-packages branch from b328d6a to 8e907b2 Compare February 22, 2026 22:15
@birkskyum birkskyum changed the title use pnpm workspace for local packages chore: use pnpm workspace for local packages Feb 22, 2026
@birkskyum birkskyum changed the title chore: use pnpm workspace for local packages refactor: use pnpm workspace for local packages Feb 22, 2026
@lxsmnsyc
Copy link
Member

lxsmnsyc commented Feb 23, 2026

hmmm, we probably also need .npmrc as a safety measure (despite the name, pnpm uses this):

prefer-workspace-packages=true
link-workspace-packages=true

@birkskyum
Copy link
Member Author

birkskyum commented Feb 23, 2026

hmmm, we probably also need .npmrc as a safety measure (despite the name, pnpm uses this):

prefer-workspace-packages=true
link-workspace-packages=true

@lxsmnsyc that won't be necessary. If the fixtures etc used

"@solidjs/start": "2.0.0-alpha.1"

Then the prefer-workspace [over the set version] would be needed. But the fixtures, landing, test etc. just have:

"@solidjs/start": "workspace:*"

So "prefer workspace" won't be preferred over anything - they're already set to look at the workspace first.

Browsing the pnpm lockfile shows this is working alreardy, with passages like:

      '@solidjs/vite-plugin-nitro-2':
        specifier: workspace:*
        version: link:../../../packages/start-nitro-v2-vite-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants