-
Notifications
You must be signed in to change notification settings - Fork 32
Migrate from lodash to es-toolkit #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
d5f7dd3
7108867
9540a78
870b6ba
d0f3bdf
40e4e05
0dfdaf6
00bbd27
81e4198
4cfe7d0
80e3ae4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wasn't sure what the purpose of the file was, considering I can't find any uses for it in the repo |
Large diffs are not rendered by default.
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -286,7 +286,6 @@ export default defineConfig( | |
| 'prefer-const': ['warn', { destructuring: 'all' }], | ||
|
|
||
| '@sourceacademy/default-import-name': ['warn', { path: 'pathlib' }], | ||
| '@sourceacademy/no-barrel-imports': ['error', ['lodash']], | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Revert |
||
| '@sourceacademy/region-comment': 'error', | ||
| } | ||
| }, | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -74,6 +74,8 @@ | |||||
| "husky": "^9.1.7", | ||||||
| "jsdom": "^26.1.0", | ||||||
| "jsonc-eslint-parser": "^2.4.0", | ||||||
| "react": "^18.3.1", | ||||||
| "react-dom": "^18.3.1", | ||||||
|
Comment on lines
+77
to
+78
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Revert
Suggested change
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the tests were failing without react in package.json for some reason |
||||||
| "typescript": "^5.8.2", | ||||||
| "typescript-eslint": "^8.53.1", | ||||||
| "vitest": "^4.0.18", | ||||||
|
|
@@ -82,8 +84,8 @@ | |||||
| "peerDependencies": { | ||||||
| "@blueprintjs/core": "^6.0.0", | ||||||
| "@blueprintjs/icons": "^6.0.0", | ||||||
| "es-toolkit": "^1.44.0", | ||||||
| "js-slang": "^1.0.85", | ||||||
| "lodash": "^4.17.23", | ||||||
| "react": "^18.3.1", | ||||||
| "react-dom": "^18.3.1" | ||||||
| }, | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to update these?