Decrease number of secrets by moving them to envs if applicable#1704
Open
kasiakoziol wants to merge 14 commits intodevelopfrom
Open
Decrease number of secrets by moving them to envs if applicable#1704kasiakoziol wants to merge 14 commits intodevelopfrom
kasiakoziol wants to merge 14 commits intodevelopfrom
Conversation
kasiakoziol
force-pushed
the
feature/decrease-number-of-secrets
branch
from
4c07832 to
097ee97
Compare
Collaborator
Pull Request Test Coverage Report for Build 22846137391Details
💛 - Coveralls |
kasiakoziol
requested review from
Igor-splunk,
gabrielm-splunk,
minjieqiu,
patrykw-splunk,
qingw-splunk and
vivekr-splunk
| SPLUNK_OPERATOR_IMAGE_NAME: splunk/splunk-operator | ||
| ECR_REPOSITORY: ${{ secrets.ECR_REPOSITORY }} | ||
| S3_REGION: ${{ secrets.AWS_DEFAULT_REGION }} | ||
| S3_REGION: ${{ vars.AWS_DEFAULT_REGION }} |
Collaborator
There was a problem hiding this comment.
can this be env.AWS_DEFAULT_REGION
Collaborator
Author
There was a problem hiding this comment.
I wanted to use env instead of vars, but it ended up with many issues with reading the value from .env, so switched to vars.
Collaborator
Author
There was a problem hiding this comment.
e.g.
Invalid workflow file: .github/workflows/arm-AL2023-build-test-push-workflow-AL2023.yml#L1
(Line: 65, Col: 18): Unrecognized named-value: 'steps'. Located at position 1 within expression: steps.dotenv.outputs.AWS_DEFAULT_REGION, (Line: 141, Col: 18): Unrecognized named-value: 'steps'. Located at position 1 within expression: steps.dotenv.outputs.AWS_DEFAULT_REGION
Collaborator
Author
There was a problem hiding this comment.
Collaborator
vivekr-splunk
left a comment
vivekr-splunk
left a comment
There was a problem hiding this comment.
can AWS_DEFAULT_REGION this be env.AWS_DEFAULT_REGION
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR decreases the number of secrets by moving some of the values that are not secrets to standard env variables.
Key Changes
Changes apply to:
Testing and Verification
Automated tests
Related Issues
PR Checklist