Open
Conversation
Continuing from previous changes, add a persistent buffer into which the message payload is decrypted, rather than allocating a new array each time.
Rob-Hague
requested review from
WojciechNagorski and
drieseng
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing from previous changes, add a persistent buffer into which the message payload is decrypted, rather than allocating a new array each time.
With this change and #1733, #1738 (plus #1650 in 2025.1.0), allocations for the server-to-client (e.g. download) direction are significantly reduced compared to previous versions.
(SFTP)
Footnotes
Bi-modal between 4x and 5x of file size before Use an array buffer for the sftp packet stream #1649 in 2025.1.0 ↩